From: Rae Moar <rmoar@google.com>
To: brendanhiggins@google.com, davidgow@google.com, dlatypov@google.com
Cc: skhan@linuxfoundation.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Rae Moar <rmoar@google.com>
Subject: [PATCH v1] kunit: add tests for using current KUnit test field
Date: Thu, 30 Mar 2023 22:05:06 +0000 [thread overview]
Message-ID: <20230330220506.1399796-1-rmoar@google.com> (raw)
Create test suite called "kunit_current" to add test coverage for the use
of current->kunit_test, which returns the current KUnit test.
Add three test cases:
- kunit_current_kunit_test_field to test the use of current->kunit_test.
- kunit_current_get_current_test to test the method
kunit_get_current_test(), which utilizes current->kunit_test.
- kunit_current_fail_current_test to test the method
kunit_fail_current_test(), which utilizes current->kunit_test.
Signed-off-by: Rae Moar <rmoar@google.com>
---
lib/kunit/kunit-test.c | 61 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 60 insertions(+), 1 deletion(-)
diff --git a/lib/kunit/kunit-test.c b/lib/kunit/kunit-test.c
index b63595d3e241..91984b92c916 100644
--- a/lib/kunit/kunit-test.c
+++ b/lib/kunit/kunit-test.c
@@ -6,6 +6,7 @@
* Author: Brendan Higgins <brendanhiggins@google.com>
*/
#include <kunit/test.h>
+#include <kunit/test-bug.h>
#include "try-catch-impl.h"
@@ -532,7 +533,65 @@ static struct kunit_suite kunit_status_test_suite = {
.test_cases = kunit_status_test_cases,
};
+static void kunit_current_kunit_test_field(struct kunit *test)
+{
+ struct kunit *current_test;
+
+ /* Check to ensure the result of current->kunit_test
+ * is equivalent to current test.
+ */
+ current_test = current->kunit_test;
+ KUNIT_EXPECT_PTR_EQ(test, test, current_test);
+}
+
+static void kunit_current_get_current_test(struct kunit *test)
+{
+ struct kunit *current_test1, *current_test2;
+
+ /* Check to ensure the result of kunit_get_current_test()
+ * is equivalent to current test.
+ */
+ current_test1 = kunit_get_current_test();
+ KUNIT_EXPECT_PTR_EQ(test, test, current_test1);
+
+ /* Check to ensure the result of kunit_get_current_test()
+ * is equivalent to current->kunit_test.
+ */
+ current_test2 = current->kunit_test;
+ KUNIT_EXPECT_PTR_EQ(test, current_test1, current_test2);
+}
+
+static void kunit_current_fail_current_test(struct kunit *test)
+{
+ struct kunit fake;
+
+ /* Initialize fake test and set as current->kunit_test. */
+ kunit_init_test(&fake, "fake test", NULL);
+ KUNIT_EXPECT_EQ(test, fake.status, KUNIT_SUCCESS);
+ current->kunit_test = &fake;
+
+ /* Fail current test and expect status of fake test to be failed. */
+ kunit_fail_current_test("This test is supposed to fail.");
+ KUNIT_EXPECT_EQ(test, fake.status, (enum kunit_status)KUNIT_FAILURE);
+
+ /* Reset current->kunit_test to current test. */
+ current->kunit_test = test;
+}
+
+static struct kunit_case kunit_current_test_cases[] = {
+ KUNIT_CASE(kunit_current_kunit_test_field),
+ KUNIT_CASE(kunit_current_get_current_test),
+ KUNIT_CASE(kunit_current_fail_current_test),
+ {}
+};
+
+static struct kunit_suite kunit_current_test_suite = {
+ .name = "kunit_current",
+ .test_cases = kunit_current_test_cases,
+};
+
kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite,
- &kunit_log_test_suite, &kunit_status_test_suite);
+ &kunit_log_test_suite, &kunit_status_test_suite,
+ &kunit_current_test_suite);
MODULE_LICENSE("GPL v2");
base-commit: 7232282dd47cce6a780c9414bd9baccf232c7686
--
2.40.0.348.gf938b09366-goog
next reply other threads:[~2023-03-30 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 22:05 Rae Moar [this message]
2023-03-30 22:20 ` Daniel Latypov
2023-03-31 8:15 ` David Gow
2023-04-03 19:31 ` Rae Moar
2023-04-03 23:09 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330220506.1399796-1-rmoar@google.com \
--to=rmoar@google.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®