From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAC5C761AF for ; Thu, 30 Mar 2023 22:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbjC3W3f (ORCPT ); Thu, 30 Mar 2023 18:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjC3W3c (ORCPT ); Thu, 30 Mar 2023 18:29:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2484211F; Thu, 30 Mar 2023 15:29:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64BDC621C1; Thu, 30 Mar 2023 22:29:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC7A5C433D2; Thu, 30 Mar 2023 22:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680215370; bh=u2AAe8FW/d2n59lqS7oxavb/IFRSqDdeC/+2NOlYXK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AUlflJsHxIOWgUT8O51/LP3fvE+9CyMewxcLGkAwdlQZ/H6ZsEKF2KE3nKN1Ne6Wl ub3IbFjL4UMTqa/YilAfGgiGN7fKyCAmN15sdnrUCuvaSu0ex3iJ+ROlvHaLbOutTM r2MOJff0meJ5288S/Vy8745DraPnWP33+SqkeHd7MIctbhNWtJj3af4Fx8pBkPYM1z mZufZAet1ZMNREpUalbCkfJLP9VjwZH4tDbiQnFMitrYNon+zYhEyEylGIMbz1A//r fhAtB2eaMa202c6M0GWDq5KpMctuL2nPH5Dv9+WZypHfUujGzukIGVRRwTJvFrFQEy RDtSQJIxPstIA== Date: Thu, 30 Mar 2023 15:29:28 -0700 From: Nathan Chancellor To: Alyssa Ross Cc: Masahiro Yamada , Nick Cao , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, Tom Rix , Albert Ou , Palmer Dabbelt , Paul Walmsley , stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v3] purgatory: fix disabling debug info Message-ID: <20230330222928.GA644044@dev-arch.thelio-3990X> References: <20230330182223.181775-1-hi@alyssa.is> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330182223.181775-1-hi@alyssa.is> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 06:22:24PM +0000, Alyssa Ross wrote: > Since 32ef9e5054ec, -Wa,-gdwarf-2 is no longer used in KBUILD_AFLAGS. > Instead, it includes -g, the appropriate -gdwarf-* flag, and also the > -Wa versions of both of those if building with Clang and GNU as. As a > result, debug info was being generated for the purgatory objects, even > though the intention was that it not be. > > Fixes: 32ef9e5054ec ("Makefile.debug: re-enable debug info for .S files") > Signed-off-by: Alyssa Ross > Cc: stable@vger.kernel.org > Acked-by: Nick Desaulniers This is definitely more future proof. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > v2: https://lore.kernel.org/r/20230326182120.194541-1-hi@alyssa.is > > Difference from v2: replaced asflags-remove-y with every possible > debug flag with asflags-y += -g0, as suggested by Nick Desaulniers. > > Additionally, I've CCed the x86 maintainers this time, since Masahiro > said he would like acks from subsystem maintainers, and > get_maintainer.pl didn't pick them the first time around. > > arch/riscv/purgatory/Makefile | 7 +------ > arch/x86/purgatory/Makefile | 3 +-- > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/riscv/purgatory/Makefile b/arch/riscv/purgatory/Makefile > index d16bf715a586..9c1e71853ee7 100644 > --- a/arch/riscv/purgatory/Makefile > +++ b/arch/riscv/purgatory/Makefile > @@ -84,12 +84,7 @@ CFLAGS_string.o += $(PURGATORY_CFLAGS) > CFLAGS_REMOVE_ctype.o += $(PURGATORY_CFLAGS_REMOVE) > CFLAGS_ctype.o += $(PURGATORY_CFLAGS) > > -AFLAGS_REMOVE_entry.o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_memcpy.o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_memset.o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_strcmp.o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_strlen.o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_strncmp.o += -Wa,-gdwarf-2 > +asflags-y += -g0 > > $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE > $(call if_changed,ld) > diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile > index 17f09dc26381..8e6c81b1c8f7 100644 > --- a/arch/x86/purgatory/Makefile > +++ b/arch/x86/purgatory/Makefile > @@ -69,8 +69,7 @@ CFLAGS_sha256.o += $(PURGATORY_CFLAGS) > CFLAGS_REMOVE_string.o += $(PURGATORY_CFLAGS_REMOVE) > CFLAGS_string.o += $(PURGATORY_CFLAGS) > > -AFLAGS_REMOVE_setup-x86_$(BITS).o += -Wa,-gdwarf-2 > -AFLAGS_REMOVE_entry64.o += -Wa,-gdwarf-2 > +asflags-y += -g0 > > $(obj)/purgatory.ro: $(PURGATORY_OBJS) FORCE > $(call if_changed,ld) > -- > 2.37.1 > >