From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997A5C761A6 for ; Fri, 31 Mar 2023 18:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232184AbjCaSDD (ORCPT ); Fri, 31 Mar 2023 14:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229983AbjCaSDB (ORCPT ); Fri, 31 Mar 2023 14:03:01 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 915F7B769; Fri, 31 Mar 2023 11:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680285778; x=1711821778; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1ZE2ydukO2Pi03RV+PLnVNWf0erf6eWYtcxgNoWA6ks=; b=SBSoccinQPeSmPnwUBf5Vx1bX/tuc7XKHsR8zWaDa3AKdib0BeBYXAIU 4mtCnB33B5zJtePQZY1eG4Dqe8p9L5a2vECYSWxEZpvpW9R6jsZctZKAR rfWw9ysLAbqlnwsHO6he6z0bHhjK/Bscef/sHTcTjVnu+WWzgT90uyngm DxLbWSYYZuxCu4FBzs7weQB+377ZSTGKE3VZLF4gj7Q0jA3tdG/kBIUIW l74aDjP2axhaLr5MVPm7pk1vMUeggtO6BOwdovP3QATe69jS5qfiaplvZ xOjSZYsX4Wn95tlinbe6qxnQHPusBSutnOpnHsGyWt6fJXjK2eAganGRg g==; X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="339021794" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="339021794" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 11:02:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10666"; a="828805835" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="828805835" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 31 Mar 2023 11:02:49 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1piJ5M-000M1Z-2c; Fri, 31 Mar 2023 18:02:48 +0000 Date: Sat, 1 Apr 2023 02:02:35 +0800 From: kernel test robot To: Sebastian Reichel , Heiko Stuebner , linux-rockchip@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, Peter Geis , Elaine Zhang , Finley Xiao , Jagan Teki , Michael Turquette , Stephen Boyd , Boris Brezillon , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel Subject: Re: [PATCHv1 2/2] soc: rockchip: power-domain: add rk3588 mem module support Message-ID: <202304010108.ta6EkS7C-lkp@intel.com> References: <20230331163058.5688-3-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331163058.5688-3-sebastian.reichel@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, I love your patch! Yet something to improve: [auto build test ERROR on rockchip/for-next] [also build test ERROR on linus/master v6.3-rc4 next-20230331] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Reichel/clk-rockchip-rk3588-make-gate-linked-clocks-ignore-unused/20230401-003605 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next patch link: https://lore.kernel.org/r/20230331163058.5688-3-sebastian.reichel%40collabora.com patch subject: [PATCHv1 2/2] soc: rockchip: power-domain: add rk3588 mem module support config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230401/202304010108.ta6EkS7C-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/8a9b7bc14bff10030ef40e0350429490ff984f26 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sebastian-Reichel/clk-rockchip-rk3588-make-gate-linked-clocks-ignore-unused/20230401-003605 git checkout 8a9b7bc14bff10030ef40e0350429490ff984f26 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/soc/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304010108.ta6EkS7C-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/soc/rockchip/pm_domains.c: In function 'rockchip_pmu_domain_mem_reset': >> drivers/soc/rockchip/pm_domains.c:462:9: error: implicit declaration of function 'dsb' [-Werror=implicit-function-declaration] 462 | dsb(sy); | ^~~ >> drivers/soc/rockchip/pm_domains.c:462:13: error: 'sy' undeclared (first use in this function); did you mean 's8'? 462 | dsb(sy); | ^~ | s8 drivers/soc/rockchip/pm_domains.c:462:13: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/dsb +462 drivers/soc/rockchip/pm_domains.c 441 442 static int rockchip_pmu_domain_mem_reset(struct rockchip_pm_domain *pd) 443 { 444 struct rockchip_pmu *pmu = pd->pmu; 445 struct generic_pm_domain *genpd = &pd->genpd; 446 bool is_on; 447 int ret = 0; 448 449 ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_chain_on, pd, is_on, 450 is_on == true, 0, 10000); 451 if (ret) { 452 dev_err(pmu->dev, 453 "failed to get chain status '%s', target_on=1, val=%d\n", 454 genpd->name, is_on); 455 goto error; 456 } 457 458 udelay(20); 459 460 regmap_write(pmu->regmap, pmu->info->mem_pwr_offset + pd->info->pwr_offset, 461 (pd->info->pwr_mask | pd->info->pwr_w_mask)); > 462 dsb(sy); 463 464 ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_mem_on, pd, is_on, 465 is_on == false, 0, 10000); 466 if (ret) { 467 dev_err(pmu->dev, 468 "failed to get mem status '%s', target_on=0, val=%d\n", 469 genpd->name, is_on); 470 goto error; 471 } 472 473 regmap_write(pmu->regmap, pmu->info->mem_pwr_offset + pd->info->pwr_offset, 474 pd->info->pwr_w_mask); 475 dsb(sy); 476 477 ret = readx_poll_timeout_atomic(rockchip_pmu_domain_is_mem_on, pd, is_on, 478 is_on == true, 0, 10000); 479 if (ret) { 480 dev_err(pmu->dev, 481 "failed to get mem status '%s', target_on=1, val=%d\n", 482 genpd->name, is_on); 483 } 484 485 error: 486 return ret; 487 } 488 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests