From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: linux-kernel@vger.kernel.org
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
"Dario Binacchi" <dario.binacchi@amarulasolutions.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Oliver Graute" <oliver.graute@kococonnector.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-input@vger.kernel.org
Subject: [PATCH 8/9] Input: edt-ft5x06 - unify the crc check
Date: Sun, 2 Apr 2023 22:09:50 +0200 [thread overview]
Message-ID: <20230402200951.1032513-9-dario.binacchi@amarulasolutions.com> (raw)
In-Reply-To: <20230402200951.1032513-1-dario.binacchi@amarulasolutions.com>
With this patch, the CRC is always verified by the same function, even in
the case of accessing registers where the number of bytes is minimal.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 8aae4c1e6b73..fdb32e3591be 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -240,13 +240,10 @@ static int edt_M06_i2c_read(void *context, const void *reg_buf, size_t reg_size,
if (!edt_ft5x06_ts_check_crc(tsdata, val_buf, val_size))
return -EIO;
} else if (reg_read) {
- u8 crc = wbuf[0] ^ wbuf[1] ^ rbuf[0];
-
- if (crc != rbuf[1]) {
- dev_err(dev, "crc error: 0x%02x expected, got 0x%02x\n",
- crc, rbuf[1]);
+ wbuf[2] = rbuf[0];
+ wbuf[3] = rbuf[1];
+ if (!edt_ft5x06_ts_check_crc(tsdata, wbuf, 4))
return -EIO;
- }
*((u8 *)val_buf) = rbuf[0];
}
--
2.32.0
next prev parent reply other threads:[~2023-04-02 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 20:09 [PATCH 0/9] Input: edt-ft5x06 - convert to use regmap API Dario Binacchi
2023-04-02 20:09 ` [PATCH 1/9] Input: edt-ft5x06 - fix indentation Dario Binacchi
2023-04-02 20:09 ` [PATCH 2/9] Input: edt-ft5x06 - remove unnecessary blank lines Dario Binacchi
2023-04-02 20:09 ` [PATCH 3/9] Input: edt-ft5x06 - add spaces to ensure format specification Dario Binacchi
2023-04-02 20:09 ` [PATCH 4/9] Input: edt-ft5x06 - don't recalculate the CRC Dario Binacchi
2023-04-02 20:09 ` [PATCH 5/9] Input: edt-ft5x06 - remove code duplication Dario Binacchi
2023-04-02 20:09 ` [PATCH 6/9] Input: edt-ft5x06 - don't print error messages with dev_dbg() Dario Binacchi
2023-04-02 20:09 ` [PATCH 7/9] Input: edt-ft5x06 - convert to use regmap API Dario Binacchi
2023-04-02 20:09 ` Dario Binacchi [this message]
2023-04-02 20:09 ` [PATCH 9/9] Input: edt-ft5x06: Calculate points data length only once Dario Binacchi
2023-04-03 4:40 ` [PATCH 0/9] Input: edt-ft5x06 - convert to use regmap API Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230402200951.1032513-9-dario.binacchi@amarulasolutions.com \
--to=dario.binacchi@amarulasolutions.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=oliver.graute@kococonnector.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®