From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Eddie Hung <eddie.hung@mediatek.com>,
Tianping Fang <tianping.fang@mediatek.com>
Subject: [PATCH 2/7] usb: mtu3: use boolean return value
Date: Mon, 3 Apr 2023 10:52:25 +0800 [thread overview]
Message-ID: <20230403025230.25035-2-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <20230403025230.25035-1-chunfeng.yun@mediatek.com>
Prefer to use boolean value due to gpd_ring_empty() return true or false.
See "16) Function return values and names" in coding-style.rst
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/mtu3/mtu3_qmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
index 7be4e4be1a6a..66639f602a9d 100644
--- a/drivers/usb/mtu3/mtu3_qmu.c
+++ b/drivers/usb/mtu3/mtu3_qmu.c
@@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring)
}
/* check if a ring is emtpy */
-static int gpd_ring_empty(struct mtu3_gpd_ring *ring)
+static bool gpd_ring_empty(struct mtu3_gpd_ring *ring)
{
struct qmu_gpd *enq = ring->enqueue;
struct qmu_gpd *next;
--
2.18.0
next prev parent reply other threads:[~2023-04-03 2:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 2:52 [PATCH 1/7] usb: mtu3: give back request when rx error happens Chunfeng Yun
2023-04-03 2:52 ` Chunfeng Yun [this message]
2023-04-03 12:31 ` [PATCH 2/7] usb: mtu3: use boolean return value AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 3/7] usb: mtu3: fix KE at qmu transfer done irq handler Chunfeng Yun
2023-04-03 12:31 ` AngeloGioacchino Del Regno
2023-04-07 7:59 ` Chunfeng Yun (云春峰)
2023-04-07 9:08 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 4/7] usb: mtu3: unlock @mtu->lock just before giving back request Chunfeng Yun
2023-04-03 12:31 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 5/7] usb: mtu3: expose role-switch control to userspace Chunfeng Yun
2023-04-03 12:34 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks Chunfeng Yun
2023-04-04 13:43 ` Rob Herring
2023-04-07 8:03 ` Chunfeng Yun (云春峰)
2023-04-03 2:52 ` [PATCH 7/7] usb: mtu3: add optional clock xhci_ck and frmcnt_ck Chunfeng Yun
2023-04-03 12:34 ` AngeloGioacchino Del Regno
2023-04-07 8:12 ` Chunfeng Yun (云春峰)
2023-04-03 12:31 ` [PATCH 1/7] usb: mtu3: give back request when rx error happens AngeloGioacchino Del Regno
2023-04-07 7:24 ` Chunfeng Yun (云春峰)
2023-04-17 1:07 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403025230.25035-2-chunfeng.yun@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tianping.fang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®