From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E23AC76188 for ; Mon, 3 Apr 2023 15:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232411AbjDCP3h (ORCPT ); Mon, 3 Apr 2023 11:29:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbjDCP3b (ORCPT ); Mon, 3 Apr 2023 11:29:31 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7015C30FB for ; Mon, 3 Apr 2023 08:29:18 -0700 (PDT) Received: from LAPTOP-6NFQSDTK.localdomain ([10.12.182.145]) (user=yll@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 333FS2bR027146-333FS2bS027146 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 3 Apr 2023 23:28:08 +0800 From: Liliang Ye To: Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: hust-os-kernel-patches@googlegroups.com, Liliang Ye , Dan Carpenter , Shengjiu Wang , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path Date: Mon, 3 Apr 2023 23:27:37 +0800 Message-Id: <20230403152737.17671-1-yll@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: yll@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pm_runtime_disable was missed in cleanup operation, which corresponds to the earlier call to pm_runtime_enable. To fix this, add pm_runtime_disable() on error path. Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver") Signed-off-by: Liliang Ye Reviewed-by: Dan Carpenter --- sound/soc/fsl/fsl_mqs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index 32d20d351bbf..129d426c60c4 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mqs.c @@ -251,9 +251,13 @@ static int fsl_mqs_probe(struct platform_device *pdev) ret = devm_snd_soc_register_component(&pdev->dev, &soc_codec_fsl_mqs, &fsl_mqs_dai, 1); if (ret) - return ret; + goto err_pm_disable; return 0; + +err_pm_disable: + pm_runtime_disable(&pdev->dev); + return ret; } static int fsl_mqs_remove(struct platform_device *pdev) -- 2.34.1