From: Mario Limonciello <mario.limonciello@amd.com>
To: Sven van Ashbrook <svenva@chromium.org>,
John Stultz <jstultz@google.com>,
Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
David E Box <david.e.box@intel.com>
Cc: Raul Rangel <rrangel@chromium.org>,
Rajat Jain <rajatja@google.com>,
"S-k Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
<linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
Mark Gross <markgross@kernel.org>
Subject: [PATCH v6 4/4] platform/x86/intel/pmc: core: Report duration of time in HW sleep state
Date: Mon, 3 Apr 2023 16:18:30 -0500 [thread overview]
Message-ID: <20230403211831.4010-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230403211831.4010-1-mario.limonciello@amd.com>
intel_pmc_core displays a warning when the module parameter
`warn_on_s0ix_failures` is set and a suspend didn't get to a HW sleep
state.
Report this to the standard kernel reporting infrastructure so that
userspace software can query after the suspend cycle is done.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v5->v6:
* Handle overflow case
* Use renamed symbol
v4->v5:
* Reword commit message
---
drivers/platform/x86/intel/pmc/core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index 925c5d676a43..0621756792c8 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -1214,6 +1214,11 @@ static inline bool pmc_core_is_s0ix_failed(struct pmc_dev *pmcdev)
if (pmc_core_dev_state_get(pmcdev, &s0ix_counter))
return false;
+ if (s0ix_counter >= pmcdev->s0ix_counter)
+ pm_report_hw_sleep_time(s0ix_counter - pmcdev->s0ix_counter);
+ else
+ pm_report_hw_sleep_time(U64_MAX);
+
if (s0ix_counter == pmcdev->s0ix_counter)
return true;
--
2.34.1
next prev parent reply other threads:[~2023-04-03 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 21:18 [PATCH v6 0/4] Add vendor agnostic mechanism to report hardware sleep Mario Limonciello
2023-04-03 21:18 ` [PATCH v6 1/4] PM: Add sysfs files to represent time spent in hardware sleep state Mario Limonciello
2023-04-05 0:42 ` Box, David E
2023-04-06 12:30 ` Hans de Goede
2023-04-03 21:18 ` [PATCH v6 2/4] platform/x86/amd: pmc: Report duration of time in hw " Mario Limonciello
2023-04-03 21:18 ` [PATCH v6 3/4] platform/x86/intel/pmc: core: Always capture counters on suspend Mario Limonciello
2023-04-03 21:18 ` Mario Limonciello [this message]
2023-04-05 1:00 ` [PATCH v6 4/4] platform/x86/intel/pmc: core: Report duration of time in HW sleep state Box, David E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403211831.4010-5-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=rrangel@chromium.org \
--cc=svenva@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®