From: Christian Brauner <brauner@kernel.org>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan
Date: Wed, 5 Apr 2023 09:46:11 +0200 [thread overview]
Message-ID: <20230404-wasting-finicky-6f8876022a24@brauner> (raw)
In-Reply-To: <20230403205735.ltb3pmh5yl2pjzhu@distanz.ch>
On Mon, Apr 03, 2023 at 10:57:37PM +0200, Tobias Klauser wrote:
> On 2023-03-14 at 14:09:59 +0100, Christian Brauner <brauner@kernel.org> wrote:
> > On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote:
> > > Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > > added an additional test, so the number passed to ksft_set_plan needs to
> > > be bumped accordingly.
> > >
> > > Also use ksft_finished() to print results and exit. This will catch future
> > > mismatches between ksft_set_plan() and the number of tests being run.
> > >
> > > Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME")
> > > Cc: Christian Brauner <brauner@kernel.org>
> > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > > ---
> >
> > Looks good. Thanks for fixing this,
> > Reviewed-by: Christian Brauner <brauner@kernel.org>
> >
> > Feel free to take this through the selftests tree, Shuah.
>
> It looks like this hasn't made it into Linus' tree yet and I also don't
> see it in Shuah's tree. Would it be possible to still submit this for
> 6.3-rc6 given the commit it fixes has made it to Linus' tree already?
Is it in linux-next?
next prev parent reply other threads:[~2023-04-05 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:53 [PATCH] " Tobias Klauser
2023-03-14 12:34 ` [PATCH v2] " Tobias Klauser
2023-03-14 13:09 ` Christian Brauner
2023-04-03 20:57 ` Tobias Klauser
2023-04-05 7:46 ` Christian Brauner [this message]
2023-04-05 9:43 ` Tobias Klauser
2023-04-06 10:02 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404-wasting-finicky-6f8876022a24@brauner \
--to=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®