From: yq882255@163.com
To: dri-devel@lists.freedesktop.org
Cc: "Erico Nunes" <nunes.erico@gmail.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
lima@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Qiang Yu" <yuq825@gmail.com>
Subject: [PATCH 3/3] Revert "drm/lima: add usage counting method to ctx_mgr"
Date: Tue, 4 Apr 2023 08:26:01 +0800 [thread overview]
Message-ID: <20230404002601.24136-4-yq882255@163.com> (raw)
In-Reply-To: <20230404002601.24136-1-yq882255@163.com>
From: Qiang Yu <yuq825@gmail.com>
This reverts commit bccafec957a5c4b22ac29e53a39e82d0a0008348.
This is due to the depend commit has been reverted on upstream:
baad10973fdb ("Revert "drm/scheduler: track GPU active time per entity"")
Signed-off-by: Qiang Yu <yuq825@gmail.com>
---
drivers/gpu/drm/lima/lima_ctx.c | 30 +-----------------------------
drivers/gpu/drm/lima/lima_ctx.h | 3 ---
2 files changed, 1 insertion(+), 32 deletions(-)
diff --git a/drivers/gpu/drm/lima/lima_ctx.c b/drivers/gpu/drm/lima/lima_ctx.c
index e008e586fad0..891d5cd5019a 100644
--- a/drivers/gpu/drm/lima/lima_ctx.c
+++ b/drivers/gpu/drm/lima/lima_ctx.c
@@ -15,7 +15,6 @@ int lima_ctx_create(struct lima_device *dev, struct lima_ctx_mgr *mgr, u32 *id)
if (!ctx)
return -ENOMEM;
ctx->dev = dev;
- ctx->mgr = mgr;
kref_init(&ctx->refcnt);
for (i = 0; i < lima_pipe_num; i++) {
@@ -43,17 +42,10 @@ int lima_ctx_create(struct lima_device *dev, struct lima_ctx_mgr *mgr, u32 *id)
static void lima_ctx_do_release(struct kref *ref)
{
struct lima_ctx *ctx = container_of(ref, struct lima_ctx, refcnt);
- struct lima_ctx_mgr *mgr = ctx->mgr;
int i;
- for (i = 0; i < lima_pipe_num; i++) {
- struct lima_sched_context *context = &ctx->context[i];
- struct drm_sched_entity *entity = &context->base;
-
- mgr->elapsed_ns[i] += entity->elapsed_ns;
-
+ for (i = 0; i < lima_pipe_num; i++)
lima_sched_context_fini(ctx->dev->pipe + i, ctx->context + i);
- }
kfree(ctx);
}
@@ -107,23 +99,3 @@ void lima_ctx_mgr_fini(struct lima_ctx_mgr *mgr)
xa_destroy(&mgr->handles);
mutex_destroy(&mgr->lock);
}
-
-void lima_ctx_mgr_usage(struct lima_ctx_mgr *mgr, u64 usage[lima_pipe_num])
-{
- struct lima_ctx *ctx;
- unsigned long id;
-
- for (int i = 0; i < lima_pipe_num; i++)
- usage[i] = mgr->elapsed_ns[i];
-
- mutex_lock(&mgr->lock);
- xa_for_each(&mgr->handles, id, ctx) {
- for (int i = 0; i < lima_pipe_num; i++) {
- struct lima_sched_context *context = &ctx->context[i];
- struct drm_sched_entity *entity = &context->base;
-
- usage[i] += entity->elapsed_ns;
- }
- }
- mutex_unlock(&mgr->lock);
-}
diff --git a/drivers/gpu/drm/lima/lima_ctx.h b/drivers/gpu/drm/lima/lima_ctx.h
index 6068863880eb..74e2be09090f 100644
--- a/drivers/gpu/drm/lima/lima_ctx.h
+++ b/drivers/gpu/drm/lima/lima_ctx.h
@@ -12,7 +12,6 @@
struct lima_ctx {
struct kref refcnt;
struct lima_device *dev;
- struct lima_ctx_mgr *mgr;
struct lima_sched_context context[lima_pipe_num];
atomic_t guilty;
@@ -24,7 +23,6 @@ struct lima_ctx {
struct lima_ctx_mgr {
struct mutex lock;
struct xarray handles;
- u64 elapsed_ns[lima_pipe_num];
};
int lima_ctx_create(struct lima_device *dev, struct lima_ctx_mgr *mgr, u32 *id);
@@ -33,6 +31,5 @@ struct lima_ctx *lima_ctx_get(struct lima_ctx_mgr *mgr, u32 id);
void lima_ctx_put(struct lima_ctx *ctx);
void lima_ctx_mgr_init(struct lima_ctx_mgr *mgr);
void lima_ctx_mgr_fini(struct lima_ctx_mgr *mgr);
-void lima_ctx_mgr_usage(struct lima_ctx_mgr *mgr, u64 usage[lima_pipe_num]);
#endif
--
2.25.1
next prev parent reply other threads:[~2023-04-04 0:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 0:25 [PATCH 0/3] Revert lima fdinfo patchset yq882255
2023-04-04 0:25 ` [PATCH 1/3] Revert "drm/lima: add show_fdinfo for drm usage stats" yq882255
2023-04-04 19:29 ` Daniel Vetter
2023-04-04 0:26 ` [PATCH 2/3] Revert "drm/lima: allocate unique id per drm_file" yq882255
2023-04-04 0:26 ` yq882255 [this message]
2023-04-04 15:17 ` [PATCH 0/3] Revert lima fdinfo patchset Emil Velikov
2023-04-04 19:28 ` Daniel Vetter
2023-04-05 0:50 ` Qiang Yu
2023-04-05 8:43 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404002601.24136-4-yq882255@163.com \
--to=yq882255@163.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=lima@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nunes.erico@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=ville.syrjala@linux.intel.com \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®