From: kernel test robot <lkp@intel.com>
To: Dmitry Safonov <dima@arista.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, Dmitry Safonov <dima@arista.com>,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
Salam Noureddine <noureddine@arista.com>
Subject: Re: [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO
Date: Tue, 4 Apr 2023 10:21:14 +0800 [thread overview]
Message-ID: <202304041030.rTLITKDY-lkp@intel.com> (raw)
In-Reply-To: <20230403213420.1576559-2-dima@arista.com>
Hi Dmitry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 7e364e56293bb98cae1b55fd835f5991c4e96e7d]
url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
base: 7e364e56293bb98cae1b55fd835f5991c4e96e7d
patch link: https://lore.kernel.org/r/20230403213420.1576559-2-dima%40arista.com
patch subject: [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO
config: hexagon-randconfig-r041-20230403 (https://download.01.org/0day-ci/archive/20230404/202304041030.rTLITKDY-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/94408bb4cf5cbcc772ab4d70eeb73bda183c6124
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230404-054020
git checkout 94408bb4cf5cbcc772ab4d70eeb73bda183c6124
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304041030.rTLITKDY-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from net/ipv4/tcp_sigpool.c:10:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from net/ipv4/tcp_sigpool.c:10:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from net/ipv4/tcp_sigpool.c:10:
In file included from include/net/tcp.h:20:
In file included from include/linux/tcp.h:17:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:334:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> net/ipv4/tcp_sigpool.c:63:9: warning: comparison of distinct pointer types ('typeof (size) *' (aka 'unsigned int *') and 'typeof (__scratch_size) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
size = max(size, __scratch_size);
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:74:19: note: expanded from macro 'max'
#define max(x, y) __careful_cmp(x, y, >)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
7 warnings generated.
vim +63 net/ipv4/tcp_sigpool.c
43
44 /*
45 * sigpool_reserve_scratch - re-allocates scratch buffer, slow-path
46 * @size: request size for the scratch/temp buffer
47 */
48 static int sigpool_reserve_scratch(size_t size)
49 {
50 struct scratches_to_free *stf;
51 size_t stf_sz = struct_size(stf, scratches, num_possible_cpus());
52 int cpu, err = 0;
53
54 lockdep_assert_held(&cpool_mutex);
55 if (__scratch_size >= size)
56 return 0;
57
58 stf = kmalloc(stf_sz, GFP_KERNEL);
59 if (!stf)
60 return -ENOMEM;
61 stf->cnt = 0;
62
> 63 size = max(size, __scratch_size);
64 cpus_read_lock();
65 for_each_possible_cpu(cpu) {
66 void *scratch, *old_scratch;
67
68 scratch = kmalloc_node(size, GFP_KERNEL, cpu_to_node(cpu));
69 if (!scratch) {
70 err = -ENOMEM;
71 break;
72 }
73
74 old_scratch = rcu_replace_pointer(per_cpu(sigpool_scratch, cpu), scratch, lockdep_is_held(&cpool_mutex));
75 if (!cpu_online(cpu) || !old_scratch) {
76 kfree(old_scratch);
77 continue;
78 }
79 stf->scratches[stf->cnt++] = old_scratch;
80 }
81 cpus_read_unlock();
82 if (!err)
83 __scratch_size = size;
84
85 call_rcu(&stf->rcu, free_old_scratches);
86 return err;
87 }
88
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-04-04 2:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 21:33 [PATCH v5 00/21] net/tcp: Add TCP-AO support Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 01/21] [draft] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-04-04 2:10 ` kernel test robot
2023-04-04 2:21 ` kernel test robot [this message]
2023-04-04 3:44 ` kernel test robot
2023-04-03 21:34 ` [PATCH v5 02/21] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 03/21] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 04/21] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 05/21] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 06/21] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 07/21] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 08/21] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 09/21] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-04-04 2:00 ` kernel test robot
2023-04-03 21:34 ` [PATCH v5 10/21] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 11/21] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 12/21] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 13/21] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 14/21] net/tcp: Add TCP-AO SNE support Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 15/21] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 16/21] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 17/21] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 18/21] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 19/21] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 20/21] net/tcp-ao: Add static_key for TCP-AO Dmitry Safonov
2023-04-03 21:34 ` [PATCH v5 21/21] net/tcp-ao: Wire up l3index to TCP-AO Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304041030.rTLITKDY-lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome