From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: [PATCH net-next 1/3] ksz884x: remove commented-out #defines
Date: Wed, 05 Apr 2023 10:39:16 +0200 [thread overview]
Message-ID: <20230405-ksz884x-unused-code-v1-1-a3349811d5ef@kernel.org> (raw)
In-Reply-To: <20230405-ksz884x-unused-code-v1-0-a3349811d5ef@kernel.org>
Remove commented-out #defines from ksz884x driver.
These are self-evidently unused.
These #defines may have some value in documenting the hardware.
But that information may be accessed via scm history.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/micrel/ksz884x.c | 33 ---------------------------------
1 file changed, 33 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index f78e8ead8c36..f70895f2174e 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -583,15 +583,6 @@
#define PORT_REMOTE_10BT_FD 0x0002
#define PORT_REMOTE_10BT 0x0001
-/*
-#define STATIC_MAC_TABLE_ADDR 00-0000FFFF-FFFFFFFF
-#define STATIC_MAC_TABLE_FWD_PORTS 00-00070000-00000000
-#define STATIC_MAC_TABLE_VALID 00-00080000-00000000
-#define STATIC_MAC_TABLE_OVERRIDE 00-00100000-00000000
-#define STATIC_MAC_TABLE_USE_FID 00-00200000-00000000
-#define STATIC_MAC_TABLE_FID 00-03C00000-00000000
-*/
-
#define STATIC_MAC_TABLE_ADDR 0x0000FFFF
#define STATIC_MAC_TABLE_FWD_PORTS 0x00070000
#define STATIC_MAC_TABLE_VALID 0x00080000
@@ -602,13 +593,6 @@
#define STATIC_MAC_FWD_PORTS_SHIFT 16
#define STATIC_MAC_FID_SHIFT 22
-/*
-#define VLAN_TABLE_VID 00-00000000-00000FFF
-#define VLAN_TABLE_FID 00-00000000-0000F000
-#define VLAN_TABLE_MEMBERSHIP 00-00000000-00070000
-#define VLAN_TABLE_VALID 00-00000000-00080000
-*/
-
#define VLAN_TABLE_VID 0x00000FFF
#define VLAN_TABLE_FID 0x0000F000
#define VLAN_TABLE_MEMBERSHIP 0x00070000
@@ -617,17 +601,6 @@
#define VLAN_TABLE_FID_SHIFT 12
#define VLAN_TABLE_MEMBERSHIP_SHIFT 16
-/*
-#define DYNAMIC_MAC_TABLE_ADDR 00-0000FFFF-FFFFFFFF
-#define DYNAMIC_MAC_TABLE_FID 00-000F0000-00000000
-#define DYNAMIC_MAC_TABLE_SRC_PORT 00-00300000-00000000
-#define DYNAMIC_MAC_TABLE_TIMESTAMP 00-00C00000-00000000
-#define DYNAMIC_MAC_TABLE_ENTRIES 03-FF000000-00000000
-#define DYNAMIC_MAC_TABLE_MAC_EMPTY 04-00000000-00000000
-#define DYNAMIC_MAC_TABLE_RESERVED 78-00000000-00000000
-#define DYNAMIC_MAC_TABLE_NOT_READY 80-00000000-00000000
-*/
-
#define DYNAMIC_MAC_TABLE_ADDR 0x0000FFFF
#define DYNAMIC_MAC_TABLE_FID 0x000F0000
#define DYNAMIC_MAC_TABLE_SRC_PORT 0x00300000
@@ -645,12 +618,6 @@
#define DYNAMIC_MAC_ENTRIES_SHIFT 24
#define DYNAMIC_MAC_ENTRIES_H_SHIFT 8
-/*
-#define MIB_COUNTER_VALUE 00-00000000-3FFFFFFF
-#define MIB_COUNTER_VALID 00-00000000-40000000
-#define MIB_COUNTER_OVERFLOW 00-00000000-80000000
-*/
-
#define MIB_COUNTER_VALUE 0x3FFFFFFF
#define MIB_COUNTER_VALID 0x40000000
#define MIB_COUNTER_OVERFLOW 0x80000000
--
2.30.2
next prev parent reply other threads:[~2023-04-05 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 8:39 [PATCH net-next 0/3] ksz884x: remove unused functions and #defines Simon Horman
2023-04-05 8:39 ` Simon Horman [this message]
2023-04-05 8:39 ` [PATCH net-next 2/3] ksz884x: remove unused #defines Simon Horman
2023-04-06 13:37 ` Paolo Abeni
2023-04-06 16:00 ` Jakub Kicinski
2023-04-06 16:12 ` Simon Horman
2023-04-06 17:44 ` Jakub Kicinski
2023-04-06 20:06 ` Paolo Abeni
2023-04-05 8:39 ` [PATCH net-next 3/3] ksz884x: remove unused functions Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405-ksz884x-unused-code-v1-1-a3349811d5ef@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®