From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52211C6FD1D for ; Tue, 4 Apr 2023 16:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232138AbjDDQU4 (ORCPT ); Tue, 4 Apr 2023 12:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbjDDQUx (ORCPT ); Tue, 4 Apr 2023 12:20:53 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9247D3C2F for ; Tue, 4 Apr 2023 09:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680625252; x=1712161252; h=date:from:to:cc:subject:message-id:mime-version; bh=nrK8hkkDvG2ZD7xpLCEcFzwzreDEMPoFqgJUjCMmA58=; b=UjeFI/rffpTinMrVtSKK3reUCq1xMzEaXB62YHPKBGs4LX2b0J0VP+3/ +9azdTDGMAMC2pvXuG8A/PX8ak/JfHQTBVXfPYpTB1uPi9go7TXi4dyRK cwMRMb+SrgWlVW1RL1f8NA0d7mwcE7kPFq3sNbti0J0OhajU7UMbubeLb Nrl82vPUGaORiIYPacxyW1DxGCYuc3NtsTjxH6rtzPgGAOdkMmosrUYEI JFU1ERpBr8mYJJyzwhOnxZF0c6qFuFtIvK3yEfD29161ZS6A6RzZzsecD S5EwihU3y/nBh5vxkSpvOPacGutaer8QHzKEcdvIPexjMspJqydhVIwHj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="407305853" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="407305853" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2023 09:19:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="830034481" X-IronPort-AV: E=Sophos;i="5.98,318,1673942400"; d="scan'208";a="830034481" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 04 Apr 2023 09:19:34 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pjjNe-000PtL-0W; Tue, 04 Apr 2023 16:19:34 +0000 Date: Wed, 5 Apr 2023 00:19:01 +0800 From: kernel test robot To: Ard Biesheuvel Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types) Message-ID: <202304050051.J6m3zd1N-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 148341f0a2f53b5e8808d093333d85170586a15d commit: a050910972bb25152b42ad2e544652117c5ad915 efi/libstub: implement generic EFI zboot date: 7 months ago config: arm64-randconfig-s052-20230404 (https://download.01.org/0day-ci/archive/20230405/202304050051.J6m3zd1N-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a050910972bb25152b42ad2e544652117c5ad915 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout a050910972bb25152b42ad2e544652117c5ad915 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304050051.J6m3zd1N-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) drivers/firmware/efi/libstub/zboot.c: note: in included file (through drivers/firmware/efi/libstub/../../../../lib/decompress_unxz.c): >> drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@ drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: expected restricted __le32 const [usertype] *p drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:393:28: sparse: got unsigned int const [usertype] * drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@ drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: expected restricted __le32 const [usertype] *p drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:427:48: sparse: got unsigned int const [usertype] * drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@ drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: expected restricted __le32 const [usertype] *p drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:435:37: sparse: got unsigned int const [usertype] * drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected restricted __le32 const [usertype] *p @@ got unsigned int const [usertype] * @@ drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: expected restricted __le32 const [usertype] *p drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c:459:28: sparse: got unsigned int const [usertype] * drivers/firmware/efi/libstub/zboot.c:163:1: sparse: sparse: symbol 'efi_zboot_entry' was not declared. Should it be static? vim +393 drivers/firmware/efi/libstub/../../../../lib/xz/xz_dec_stream.c 24fa0402a9b6a53 Lasse Collin 2011-01-12 385 24fa0402a9b6a53 Lasse Collin 2011-01-12 386 /* Decode the Stream Header field (the first 12 bytes of the .xz Stream). */ 24fa0402a9b6a53 Lasse Collin 2011-01-12 387 static enum xz_ret dec_stream_header(struct xz_dec *s) 24fa0402a9b6a53 Lasse Collin 2011-01-12 388 { 24fa0402a9b6a53 Lasse Collin 2011-01-12 389 if (!memeq(s->temp.buf, HEADER_MAGIC, HEADER_MAGIC_SIZE)) 24fa0402a9b6a53 Lasse Collin 2011-01-12 390 return XZ_FORMAT_ERROR; 24fa0402a9b6a53 Lasse Collin 2011-01-12 391 24fa0402a9b6a53 Lasse Collin 2011-01-12 392 if (xz_crc32(s->temp.buf + HEADER_MAGIC_SIZE, 2, 0) 24fa0402a9b6a53 Lasse Collin 2011-01-12 @393 != get_le32(s->temp.buf + HEADER_MAGIC_SIZE + 2)) 24fa0402a9b6a53 Lasse Collin 2011-01-12 394 return XZ_DATA_ERROR; 24fa0402a9b6a53 Lasse Collin 2011-01-12 395 24fa0402a9b6a53 Lasse Collin 2011-01-12 396 if (s->temp.buf[HEADER_MAGIC_SIZE] != 0) 24fa0402a9b6a53 Lasse Collin 2011-01-12 397 return XZ_OPTIONS_ERROR; 24fa0402a9b6a53 Lasse Collin 2011-01-12 398 24fa0402a9b6a53 Lasse Collin 2011-01-12 399 /* 24fa0402a9b6a53 Lasse Collin 2011-01-12 400 * Of integrity checks, we support only none (Check ID = 0) and 24fa0402a9b6a53 Lasse Collin 2011-01-12 401 * CRC32 (Check ID = 1). However, if XZ_DEC_ANY_CHECK is defined, 24fa0402a9b6a53 Lasse Collin 2011-01-12 402 * we will accept other check types too, but then the check won't 24fa0402a9b6a53 Lasse Collin 2011-01-12 403 * be verified and a warning (XZ_UNSUPPORTED_CHECK) will be given. 24fa0402a9b6a53 Lasse Collin 2011-01-12 404 */ 4f8d7abaa413c34 Lasse Collin 2021-10-11 405 if (s->temp.buf[HEADER_MAGIC_SIZE + 1] > XZ_CHECK_MAX) 4f8d7abaa413c34 Lasse Collin 2021-10-11 406 return XZ_OPTIONS_ERROR; 4f8d7abaa413c34 Lasse Collin 2021-10-11 407 24fa0402a9b6a53 Lasse Collin 2011-01-12 408 s->check_type = s->temp.buf[HEADER_MAGIC_SIZE + 1]; 24fa0402a9b6a53 Lasse Collin 2011-01-12 409 :::::: The code at line 393 was first introduced by commit :::::: 24fa0402a9b6a537e87e38341e78b7da86486846 decompressors: add XZ decompressor module :::::: TO: Lasse Collin :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests