From: Marco Felsch <m.felsch@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 00/12] Rework PHY reset handling
Date: Wed, 5 Apr 2023 17:31:48 +0200 [thread overview]
Message-ID: <20230405153148.f2pk2tya67uyweki@pengutronix.de> (raw)
In-Reply-To: <da635af8-2052-40d5-846f-eda14af8c69b@lunn.ch>
Hi Andrew,
On 23-04-05, Andrew Lunn wrote:
> On Wed, Apr 05, 2023 at 11:26:51AM +0200, Marco Felsch wrote:
> > The current phy reset handling is broken in a way that it needs
> > pre-running firmware to setup the phy initially. Since the very first
> > step is to readout the PHYID1/2 registers before doing anything else.
> >
> > The whole dection logic will fall apart if the pre-running firmware
> > don't setup the phy accordingly or the kernel boot resets GPIOs states
> > or disables clocks. In such cases the PHYID1/2 read access will fail and
> > so the whole detection will fail.
> >
> > I fixed this via this series, the fix will include a new kernel API
> > called phy_device_atomic_register() which will do all necessary things
> > and return a 'struct phy_device' on success. So setting up a phy and the
> > phy state machine is more convenient.
>
> Please add a section explaining why the current API is broken beyond
> repair. You need to justify adding a new call, rather than fixing the
> existing code to just do what is necessary to allow the PHY to be
> found.
TIL from Florian that you use the cover-letter information in your merge
commits. I will adapt the cover-letter accordingly and mention why this
PR introduces a new API.
Regards,
Marco
>
> Andrew
>
next prev parent reply other threads:[~2023-04-05 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 9:26 Marco Felsch
2023-04-05 9:26 ` [PATCH 01/12] net: phy: refactor phy_device_create function Marco Felsch
2023-04-05 9:26 ` [PATCH 02/12] net: phy: refactor get_phy_device function Marco Felsch
2023-04-05 9:26 ` [PATCH 03/12] net: phy: add phy_device_set_miits helper Marco Felsch
2023-04-05 12:06 ` Andrew Lunn
2023-04-05 14:49 ` Marco Felsch
2023-04-05 9:26 ` [PATCH 04/12] net: phy: unify get_phy_device and phy_device_create parameter list Marco Felsch
2023-04-06 16:51 ` Shyam Sundar S K
2023-04-05 9:26 ` [PATCH 05/12] net: phy: add phy_id_broken support Marco Felsch
2023-04-05 12:27 ` Andrew Lunn
2023-04-05 12:30 ` Florian Fainelli
2023-04-05 15:27 ` Marco Felsch
2023-04-05 16:09 ` Andrew Lunn
2023-04-05 9:26 ` [PATCH 06/12] net: phy: add phy_device_atomic_register helper Marco Felsch
2023-04-05 12:22 ` Andrew Lunn
2023-04-05 15:22 ` Marco Felsch
2023-04-05 16:06 ` Andrew Lunn
2023-04-05 19:43 ` Marco Felsch
2023-04-05 20:34 ` Andrew Lunn
2023-04-06 8:47 ` Marco Felsch
2023-04-07 15:00 ` Andrew Lunn
2023-04-05 9:26 ` [PATCH 07/12] net: mdio: make use of " Marco Felsch
2023-04-05 9:26 ` [PATCH 08/12] net: phy: add possibility to specify mdio device parent Marco Felsch
2023-04-05 9:27 ` [PATCH 09/12] net: phy: nxp-tja11xx: make use of phy_device_atomic_register() Marco Felsch
2023-04-05 9:27 ` [PATCH 10/12] of: mdio: remove now unused of_mdiobus_phy_device_register() Marco Felsch
2023-04-05 9:27 ` [PATCH 11/12] net: mdiobus: remove now unused fwnode helpers Marco Felsch
2023-04-05 9:27 ` [PATCH 12/12] net: phy: add default gpio assert/deassert delay Marco Felsch
2023-04-05 12:39 ` Andrew Lunn
2023-04-05 12:32 ` [PATCH 00/12] Rework PHY reset handling Andrew Lunn
2023-04-05 15:31 ` Marco Felsch [this message]
2023-04-05 12:42 ` Florian Fainelli
2023-04-05 14:42 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405153148.f2pk2tya67uyweki@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iyappan@os.amperecomputing.com \
--cc=jaswinder.singh@linaro.org \
--cc=kernel@pengutronix.de \
--cc=keyur@os.amperecomputing.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quan@os.amperecomputing.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=rafael@kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®