Re: [PATCH 5.4 000/104] 5.4.240-rc1 review

[Tom Saeger <tom.saeger@oracle.com>]

On Wed, Apr 05, 2023 at 11:33:35AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 04, 2023 at 02:33:12PM -0600, Tom Saeger wrote:
> > On Mon, Apr 03, 2023 at 04:07:52PM +0200, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.4.240 release.
> > > There are 104 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Wed, 05 Apr 2023 14:03:18 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > > 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.240-rc1.gz
> > > or in the git tree and branch at:
> > > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > Hey Greg,
> > 
> > This still reproduces:
> > 
> > 
> > cp arch/mips/configs/lasat_defconfig .config
> > make ARCH=mips olddefconfig
> > make ARCH=mips
> > 
> > 
> > .../linux-stable-5.4/arch/mips/lasat/picvue_proc.c:42:44: error: expected ')' before '&' token
> >    42 | static DECLARE_TASKLET(pvc_display_tasklet, &pvc_display, 0);
> >       |                                            ^~
> >       |                                            )
> > .../linux-stable-5.4/arch/mips/lasat/picvue_proc.c: In function 'pvc_line_proc_write':
> > .../linux-stable-5.4/arch/mips/lasat/picvue_proc.c:87:20: error: 'pvc_display_tasklet' undeclared (first use in this function)
> >    87 |  tasklet_schedule(&pvc_display_tasklet);
> >       |                    ^~~~~~~~~~~~~~~~~~~
> > .../linux-stable-5.4/arch/mips/lasat/picvue_proc.c:87:20: note: each undeclared identifier is reported only once for each function it appears in
> > At top level:
> > .../linux-stable-5.4/arch/mips/lasat/picvue_proc.c:33:13: error: 'pvc_display' defined but not used [-Werror=unused-function]
> >    33 | static void pvc_display(unsigned long data)
> >       |             ^~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > 
> > Attached is mbox of fixed-up revert/backports.
> 
> Odd that no one else is reporting this.  Thanks for the patches, I've
> queued them up for the next 5.4.y release.
> 
Found it reported most recently here:

https://lore.kernel.org/stable/642d5611.630a0220.6455f.2988@mx.google.com/

Thanks taking them!

--Tom