mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yangtao Li <frank.li@vivo.com>
To: hsiangkao@linux.alibaba.com
Cc: chao@kernel.org, frank.li@vivo.com, huyue2@coolpad.com,
	jefflexu@linux.alibaba.com, linux-erofs@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, xiang@kernel.org
Subject: Re: [PATCH 2/2] erofs: remove unnecessary kobject_del()
Date: Thu,  6 Apr 2023 17:41:28 +0800	[thread overview]
Message-ID: <20230406094128.36587-1-frank.li@vivo.com> (raw)
In-Reply-To: <028a1b56-72c9-75f6-fb68-1dc5181bf2e8@linux.alibaba.com>

HI Gao Xiang,

> Would you mind taking a look at
> commit a942da24abc5 ("fs: erofs: add sanity check for kobject in erofs_unregister_sysfs")
>
> , which could be "git-blame"ed (I'd suggest looking into these
> blame first), and the related discussion was:
>
> https://lore.kernel.org/r/CAD-N9QXNx=p3-QoWzk6pCznF32CZy8kM3vvo8mamfZZ9CpUKdw@mail.gmail.com
> https://lore.kernel.org/r/20220315075152.63789-1-dzm91@hust.edu.cn

> TL;DR: I guess it could be fixed as below if kobject_del() could
> : be killed safely:
>
> 	if (sbi->s_kobj.state_in_sysfs) {
> 		kobject_put(&sbi->s_kobj);
> 		wait_for_completion(&sbi->s_kobj_unregister);
> 	}

Thanks for your review and detailed explanation.

MBR,
Yangtao

      reply	other threads:[~2023-04-06  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 14:21 [PATCH 1/2] f2fs: " Yangtao Li
2023-04-04 14:21 ` [PATCH 2/2] erofs: " Yangtao Li
2023-04-06  3:52   ` Gao Xiang
2023-04-06  9:41     ` Yangtao Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230406094128.36587-1-frank.li@vivo.com \
    --to=frank.li@vivo.com \
    --cc=chao@kernel.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huyue2@coolpad.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®