From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD6AC7618D for ; Thu, 6 Apr 2023 11:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238474AbjDFLkr (ORCPT ); Thu, 6 Apr 2023 07:40:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238562AbjDFLjc (ORCPT ); Thu, 6 Apr 2023 07:39:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F658CA01; Thu, 6 Apr 2023 04:35:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82B696458D; Thu, 6 Apr 2023 11:34:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E04D6C433A0; Thu, 6 Apr 2023 11:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680780872; bh=Mkim9FDcw9ZkkgMeZP4bqkpWTtR0d4V/v47YXQecxEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mQjV7p6pH51SM9LTBqkc7r9VjHk2hWd8VRoJZdu6bjm5vYdbUHljmPVzOQcScqqwY ttIf3/LBECm/Qse5YQi4gIpGi/XB0YwWBZ8GZnRnBRkjvWBV55oXJJcs4/ETDaRGiH Dr9nisJzEMN6ke+Z60uQYeAu0GSORdu1xqlk0RFyB695dYzXxtQjNzO7R0xqmWbaNK EFr3CXsBjFulFMqEQOuhee1oj3Kvj2Qr5AokFQoajveF3hwquSYDdYIJtolNZyNHZa KjSlZxmqmLgDSF9FJuC1dd6WJYW/7WrGiPsBw+2GzUowymI4oUICC+Z/6W40QbrK4v 0uX9o06LI3l0A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomas Henzl , "Martin K . Petersen" , Sasha Levin , kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 3/7] scsi: megaraid_sas: Fix fw_crash_buffer_show() Date: Thu, 6 Apr 2023 07:34:17 -0400 Message-Id: <20230406113421.649149-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230406113421.649149-1-sashal@kernel.org> References: <20230406113421.649149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomas Henzl [ Upstream commit 0808ed6ebbc292222ca069d339744870f6d801da ] If crash_dump_buf is not allocated then crash dump can't be available. Replace logical 'and' with 'or'. Signed-off-by: Tomas Henzl Link: https://lore.kernel.org/r/20230324135249.9733-1-thenzl@redhat.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 42d876034741c..bdd06b26e2de1 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -2983,7 +2983,7 @@ megasas_fw_crash_buffer_show(struct device *cdev, spin_lock_irqsave(&instance->crashdump_lock, flags); buff_offset = instance->fw_crash_buffer_offset; - if (!instance->crash_dump_buf && + if (!instance->crash_dump_buf || !((instance->fw_crash_state == AVAILABLE) || (instance->fw_crash_state == COPYING))) { dev_err(&instance->pdev->dev, -- 2.39.2