From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B12A0C76196
	for <linux-kernel@archiver.kernel.org>; Tue, 11 Apr 2023 22:21:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229634AbjDKWVX (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 11 Apr 2023 18:21:23 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36640 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229516AbjDKWVW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Apr 2023 18:21:22 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F5EA3C2F
        for <linux-kernel@vger.kernel.org>; Tue, 11 Apr 2023 15:21:21 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id D03C260C8C
        for <linux-kernel@vger.kernel.org>; Tue, 11 Apr 2023 22:21:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25C70C433D2;
        Tue, 11 Apr 2023 22:21:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1681251680;
        bh=sMbNE9Dg4D8/7gjAwa4mYtt+c67BjODaruWg+Qrl6Bg=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=Rl45bOsDI2Ei4ofLlQa6y6H6/v8eq/7oYXtrJ+U2lrPVslNXNpNY8a1EA5xWlazWF
         6cHIkOI49/N6WroVn8tM6Y3jmZ9i43R9tjbpZzLj0z0AYc8FX1rIdZksbh1Tq0xj43
         Ux4Gx/znqziak5NZLuoHRRQht4QXYEEvi2Lsl3wY=
Date:   Tue, 11 Apr 2023 15:21:19 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v1 1/1] kernel.h: Split out COUNT_ARGS() and
 CONCATENATE()
Message-Id: <20230411152119.c9bb83a8566e37f6d8dbc590@linux-foundation.org>
In-Reply-To: <20230411102454.85898-1-andriy.shevchenko@linux.intel.com>
References: <20230411102454.85898-1-andriy.shevchenko@linux.intel.com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 11 Apr 2023 13:24:54 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> kernel.h is being used as a dump for all kinds of stuff for a long time.
> The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> without need of the full kernel.h dependency train with it.
> 
> Here is the attempt on cleaning it up by splitting out these macros().
> 
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -13,6 +13,7 @@
>  
>  #include <linux/stdarg.h>
>  #include <linux/align.h>
> +#include <linux/args.h>

A more energetic patch would have included args.h into each file which
calls COUNT_ARGS() and CONCATENATE(), and not included args.h into
kernel.h.  And that appears to be very easy - only bpf uses these things?

In fact these macros are so weird and ugly I'd be inclined to move them
into some bpf header so we don't have to see them again.  No
args.h, which might avoid encouraging others to use them.