From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C25EC77B76 for ; Thu, 13 Apr 2023 21:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjDMVBE (ORCPT ); Thu, 13 Apr 2023 17:01:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjDMVBB (ORCPT ); Thu, 13 Apr 2023 17:01:01 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E361B8A55 for ; Thu, 13 Apr 2023 14:00:55 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6343fe70a2aso1404950b3a.0 for ; Thu, 13 Apr 2023 14:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1681419655; x=1684011655; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Po7kMV6PWfvJ0JdTbzWxvRcPOaOmD0dTKySmuNSlDE8=; b=5SO+s+WzALNpDN1F2r4RktSFMbeXUOZ5ZZ4imLVAQoXA9/lC9hm3pg4FQZHjcgDFRr 1W6P7WWYojNsiIJnPi5nuXNn2irghWpItwRXONlnThqo2JXE5P7eGdXskbXOeHw4pfWs e4/5GvOocPYZ3hDXjojyciRevZvF858Azln1xhdoJbybRGFGIr/n4fs/v2L8hdzg9s+o 8ZlfxWTij0X1M7Oqj0eJgBUQGLAU22t8D3AGl9hVEvZT5GMRqEz+FbjOT15elBmGEZRc Ug46SqyE6nfY3hF8oRes80r0DASMIbliHC9taLr+InAecO1VhkSBXbyNobEJYqH1kvC8 qBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681419655; x=1684011655; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Po7kMV6PWfvJ0JdTbzWxvRcPOaOmD0dTKySmuNSlDE8=; b=ciWZA9VsDBrvNC4i1mD2B90Nocc8HRaR+0d5HHnoLwQLE+vDu6NPewXjkg3jBPg77g C7DjERdVjYlxk8E6YlOaZIR4X4MajBx1uZ/Asoen37Fs8USNWSvTI+e6iq02USd/PKP6 ndpPwsUGuRdJ9EXCfbq6vIUy84/Qp0xeXPXJddV4S/5s9z4kgh3yl03L1paptsMwl3im G3RRTl4u8sLVAKA2SlF4a01yMFjLhQRDcvyP77nH6QaxpmlW0gKsMqkg2mlaFg4y4kGD zV6u7cGLLCVvjLZPoOyW7flgCBotmr8e1XEG+xb8bKaayBwbmcnLee9s26ZgCiqH/AOW y7bw== X-Gm-Message-State: AAQBX9eWt0AwNYrtKS9TQ8GwfZQev+qW/0jiN6BVw3TTgTMbdxZAW55P UgQCGJNodE01gpPiFnUCm+RylA== X-Google-Smtp-Source: AKy350ZeUgwDYY5eMW7ZOlxK2igrJRw/XaGk5mqSdFs2oVNX3KK71uxfEiOe9qiJLyAHAqLgA8MlqA== X-Received: by 2002:a05:6a00:2e9c:b0:636:d5be:982f with SMTP id fd28-20020a056a002e9c00b00636d5be982fmr6073105pfb.6.1681419655345; Thu, 13 Apr 2023 14:00:55 -0700 (PDT) Received: from dread.disaster.area (pa49-180-41-174.pa.nsw.optusnet.com.au. [49.180.41.174]) by smtp.gmail.com with ESMTPSA id w5-20020aa78585000000b0063824fef27asm1871769pfn.13.2023.04.13.14.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 14:00:54 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pn43n-00322H-2A; Fri, 14 Apr 2023 07:00:51 +1000 Date: Fri, 14 Apr 2023 07:00:51 +1000 From: Dave Chinner To: Yosry Ahmed Cc: David Hildenbrand , Andrew Morton , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko , Yu Zhao , Tim Chen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 3/3] mm: vmscan: refactor updating current->reclaim_state Message-ID: <20230413210051.GO3223426@dread.disaster.area> References: <20230413104034.1086717-1-yosryahmed@google.com> <20230413104034.1086717-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 04:29:43AM -0700, Yosry Ahmed wrote: > On Thu, Apr 13, 2023 at 4:21 AM David Hildenbrand wrote: > > > > On 13.04.23 12:40, Yosry Ahmed wrote: > > > During reclaim, we keep track of pages reclaimed from other means than > > > LRU-based reclaim through scan_control->reclaim_state->reclaimed_slab, > > > which we stash a pointer to in current task_struct. > > > > > > However, we keep track of more than just reclaimed slab pages through > > > this. We also use it for clean file pages dropped through pruned inodes, > > > and xfs buffer pages freed. Rename reclaimed_slab to reclaimed, and add > > > > Would "reclaimed_non_lru" be more expressive? Then, > > > > mm_account_reclaimed_pages() -> mm_account_non_lru_reclaimed_pages() > > > > > > Apart from that LGTM. > > Thanks! > > I suck at naming things. If you think "reclaimed_non_lru" is better, > then we can do that. FWIW mm_account_reclaimed_pages() was taken from > a suggestion from Dave Chinner. My initial version had a terrible > name: report_freed_pages(), so I am happy with whatever you see fit. > > Should I re-spin for this or can we change it in place? I don't care for the noise all the bikeshed painting has generated for a simple change like this. If it's a fix for a bug, and the naming is good enough, just merge it already, ok? -Dave. -- Dave Chinner david@fromorbit.com