From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Luca Vizzarro <Luca.Vizzarro@arm.com>,
linux-kernel@vger.kernel.org,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Theodore Ts'o <tytso@mit.edu>,
David Laight <David.Laight@ACULAB.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-fsdevel@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH 5/5] dnotify: Pass argument of fcntl_dirnotify as int
Date: Fri, 14 Apr 2023 14:34:22 +0200 [thread overview]
Message-ID: <20230414-vorgibt-kringeln-f8bf1ae5278e@brauner> (raw)
In-Reply-To: <20230414104625.gyzuswldwil4jlfw@quack3>
On Fri, Apr 14, 2023 at 12:46:25PM +0200, Jan Kara wrote:
> On Fri 14-04-23 11:02:12, Luca Vizzarro wrote:
> > The interface for fcntl expects the argument passed for the command
> > F_DIRNOTIFY to be of type int. The current code wrongly treats it as
> > a long. In order to avoid access to undefined bits, we should explicitly
> > cast the argument to int.
> >
> > Cc: Kevin Brodsky <Kevin.Brodsky@arm.com>
> > Cc: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
> > Cc: "Theodore Ts'o" <tytso@mit.edu>
> > Cc: David Laight <David.Laight@ACULAB.com>
> > Cc: Mark Rutland <Mark.Rutland@arm.com>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Christian Brauner <brauner@kernel.org>
> > Cc: Jeff Layton <jlayton@kernel.org>
> > Cc: Chuck Lever <chuck.lever@oracle.com>
> > Cc: linux-fsdevel@vger.kernel.org
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Luca Vizzarro <Luca.Vizzarro@arm.com>
>
> Looks good to me. Do you plan to merge this series together (perhaps
> Christian could?) or should I pick up the dnotify patch? In case someone
> else will merge the patch feel free to add:
>
> Acked-by: Jan Kara <jack@suse.cz>
Yeah, I'm happy to carry it once it's reviewed if noone objects.
next prev parent reply other threads:[~2023-04-14 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 10:02 [PATCH 0/5] Alter fcntl to handle int arguments correctly Luca Vizzarro
2023-04-14 10:02 ` [PATCH 1/5] fcntl: Cast commands with int args explicitly Luca Vizzarro
2023-04-14 10:02 ` [PATCH 2/5] fs: Pass argument to fcntl_setlease as int Luca Vizzarro
2023-04-14 10:02 ` [PATCH 3/5] pipe: Pass argument of pipe_fcntl " Luca Vizzarro
2023-04-14 10:02 ` [PATCH 4/5] memfd: Pass argument of memfd_fcntl " Luca Vizzarro
2023-04-14 10:02 ` [PATCH 5/5] dnotify: Pass argument of fcntl_dirnotify " Luca Vizzarro
2023-04-14 10:46 ` Jan Kara
2023-04-14 12:34 ` Christian Brauner [this message]
2023-04-14 12:53 ` Luca Vizzarro
2023-04-14 12:37 ` [PATCH 0/5] Alter fcntl to handle int arguments correctly Christian Brauner
2023-04-14 12:54 ` Luca Vizzarro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414-vorgibt-kringeln-f8bf1ae5278e@brauner \
--to=brauner@kernel.org \
--cc=David.Laight@ACULAB.com \
--cc=Kevin.Brodsky@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®