From: Mario Limonciello <mario.limonciello@amd.com>
To: Box David E <david.e.box@intel.com>, <jstultz@google.com>,
<pavel@ucw.cz>, <svenva@chromium.org>,
Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
Cc: Shyam-sundar.S-k@amd.com, rrangel@chromium.org,
"Jain Rajat" <rajatja@google.com>,
hdegoede@redhat.com,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v9 4/4] platform/x86/intel/pmc: core: Report duration of time in HW sleep state
Date: Thu, 13 Apr 2023 20:23:45 -0500 [thread overview]
Message-ID: <20230414012346.1946-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230414012346.1946-1-mario.limonciello@amd.com>
intel_pmc_core displays a warning when the module parameter
`warn_on_s0ix_failures` is set and a suspend didn't get to a HW sleep
state.
Report this to the standard kernel reporting infrastructure so that
userspace software can query after the suspend cycle is done.
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v8->v9:
* Use FIELD_MAX and GENMASK
* Add tags
v7->v8:
* Report max sleep as well
---
drivers/platform/x86/intel/pmc/core.c | 4 ++++
drivers/platform/x86/intel/pmc/core.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
index 925c5d676a43..298f27ba1e10 100644
--- a/drivers/platform/x86/intel/pmc/core.c
+++ b/drivers/platform/x86/intel/pmc/core.c
@@ -1153,6 +1153,8 @@ static int pmc_core_probe(struct platform_device *pdev)
pmc_core_do_dmi_quirks(pmcdev);
pmc_core_dbgfs_register(pmcdev);
+ pm_report_max_hw_sleep(FIELD_MAX(SLP_S0_RES_COUNTER_MASK) *
+ pmc_core_adjust_slp_s0_step(pmcdev, 1));
device_initialized = true;
dev_info(&pdev->dev, " initialized\n");
@@ -1214,6 +1216,8 @@ static inline bool pmc_core_is_s0ix_failed(struct pmc_dev *pmcdev)
if (pmc_core_dev_state_get(pmcdev, &s0ix_counter))
return false;
+ pm_report_hw_sleep_time((u32)(s0ix_counter - pmcdev->s0ix_counter));
+
if (s0ix_counter == pmcdev->s0ix_counter)
return true;
diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
index 51d73efceaf3..9ca9b9746719 100644
--- a/drivers/platform/x86/intel/pmc/core.h
+++ b/drivers/platform/x86/intel/pmc/core.h
@@ -16,6 +16,8 @@
#include <linux/bits.h>
#include <linux/platform_device.h>
+#define SLP_S0_RES_COUNTER_MASK GENMASK(31, 0)
+
#define PMC_BASE_ADDR_DEFAULT 0xFE000000
/* Sunrise Point Power Management Controller PCI Device ID */
--
2.34.1
next prev parent reply other threads:[~2023-04-14 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 1:23 [PATCH v9 0/4] Add vendor agnostic mechanism to report hardware sleep Mario Limonciello
2023-04-14 1:23 ` [PATCH v9 1/4] PM: Add sysfs files to represent time spent in hardware sleep state Mario Limonciello
2023-04-14 1:23 ` [PATCH v9 2/4] platform/x86/amd: pmc: Report duration of time in hw " Mario Limonciello
2023-04-14 1:23 ` [PATCH v9 3/4] platform/x86/intel/pmc: core: Always capture counters on suspend Mario Limonciello
2023-04-14 1:23 ` Mario Limonciello [this message]
2023-04-17 8:24 ` [PATCH v9 0/4] Add vendor agnostic mechanism to report hardware sleep Hans de Goede
2023-04-17 11:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414012346.1946-5-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=david.e.box@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajatja@google.com \
--cc=rrangel@chromium.org \
--cc=svenva@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®