From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2305C77B72 for ; Fri, 14 Apr 2023 15:18:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbjDNPSF (ORCPT ); Fri, 14 Apr 2023 11:18:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbjDNPR7 (ORCPT ); Fri, 14 Apr 2023 11:17:59 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0AA2737 for ; Fri, 14 Apr 2023 08:17:36 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso15048042wmr.0 for ; Fri, 14 Apr 2023 08:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681485454; x=1684077454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LiiGjyqX4o159cvbNlKsXJAHA/ueLUd6Q3sCWwwpz5Y=; b=DOaKY7KMiuRzv77phiJcAAJ0NvzAbTEawUceJCq6OubBbrOFy3Y2WowDMWM1MdGYR3 qnxbuVikIfwiaWU3C/6stDlcrBYUtEJPZC6mXfRzfuRNK1brACCZs8MqXBEc8IqMZheI OoWJkk6gu7SDNrsmn4lCNzIOyj6jABoMy3GDDBFa1fJz40ZVsCmKSbFNvSbb1MHdqYlp 782o1F334MH2N07jMwV2b4JQVr9ztDdcdcwufcgZ2rq0bOXHMrWvDwQWE1kepwuQKTvG iu5v4ZDskKltIMbH1D19AeTWfSDxUKF4ulyKN1T/UUaFGah5Elk+bCXeFQyc7lmYPPJd EIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681485454; x=1684077454; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LiiGjyqX4o159cvbNlKsXJAHA/ueLUd6Q3sCWwwpz5Y=; b=gGbeYRKd8AffB0B6Ib0iam8j0RUfGp6N+tzZ5jkWAtbYs49nxcZUOCTrpGmqswty9W oqZuaarjQ8aqmMcvltGlVGtioeBwX5wRe4HYHjkkqSVPKOgyUlgGETE+9W+wkoMlkXVU f+RAgpMb/GiZNRX6YhPtaEdyPjoajNo2zYRv+I+q35FES80uqjzkxopzG0RcDy1l+v9w egfdjMFTg8jws1w3Kg3uMnr/uGIdtq2o/VZjeyiTv+9SO7vpSZCSLHNqd4vloclnhhcm VTbkcG+H1Yw2yPITorejMQ9IpxZpZNm5SSaXweXu1hpLibOiCfWuSYp72Ok182GR+4XU 0qOw== X-Gm-Message-State: AAQBX9crYdVJYo6mUI9w3OUVuGfx+e7Fk/PEISFIYrWbEiSjM8rV5qZE 7lTCspzaKrjlnufUqn4/ECV8Sg== X-Google-Smtp-Source: AKy350bQFzW/yiQUVEbMS8iwEGtjIIv6F3QJDvhfsmxOMugGGxPwOpR0bNIgwlJINtCCORADLPrWlg== X-Received: by 2002:a05:600c:21cf:b0:3ef:3ce6:7c54 with SMTP id x15-20020a05600c21cf00b003ef3ce67c54mr4860044wmj.35.1681485454655; Fri, 14 Apr 2023 08:17:34 -0700 (PDT) Received: from myrica (054592b0.skybroadband.com. [5.69.146.176]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c228800b003edef091b17sm4508021wmf.37.2023.04.14.08.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 08:17:34 -0700 (PDT) Date: Fri, 14 Apr 2023 16:17:35 +0100 From: Jean-Philippe Brucker To: Akihiko Odaki Cc: Eric Auger , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: virtio-iommu hotplug issue Message-ID: <20230414151735.GA4145625@myrica> References: <15bf1b00-3aa0-973a-3a86-3fa5c4d41d2c@daynix.com> <20230413104041.GA3295191@myrica> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2023 at 08:01:54PM +0900, Akihiko Odaki wrote: > Yes, that's right. The guest can dynamically create and delete VFs. The > device is emulated by QEMU: igb, an Intel NIC recently added to QEMU and > projected to be released as part of QEMU 8.0. Ah great, that's really useful, I'll add it to my tests > > Yes, I think this is an issue in the virtio-iommu driver, which should be > > sending a DETACH request when the VF is disabled, likely from > > viommu_release_device(). I'll work on a fix unless you would like to do it > > It will be nice if you prepare a fix. I will test your patch with my > workload if you share it with me. I sent a fix: https://lore.kernel.org/linux-iommu/20230414150744.562456-1-jean-philippe@linaro.org/ Thank you for reporting this, it must have been annoying to debug Thanks, Jean