mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86/urgent for v6.3-rc7
Date: Mon, 17 Apr 2023 11:04:12 +0200	[thread overview]
Message-ID: <20230417090412.GAZD0LjH5ZIaGUdoHH@fat_crate.local> (raw)
In-Reply-To: <CAHk-=wjOZgMu2VYBHMt-yFvurAqWsxLG8wh59km=B245CXRKxA@mail.gmail.com>

On Sun, Apr 16, 2023 at 10:33:19AM -0700, Linus Torvalds wrote:
> On Sun, Apr 16, 2023 at 5:29 AM Borislav Petkov <bp@alien8.de> wrote:
> >
> > - Drop __init annotation from two rtc functions which get called after
> >   boot is done, in order to prevent a crash
> 
> .. ahh, and our automation to catch these things didn't find it,
> because they are only accessed from x86_wallclock_init(), which is
> also __init.
> 
> So it all looked superficially good, except for the "oh, we saved them
> into a data structure that _isn't_ init".
> 
> It would require automation much smarter than the one we have to catch
> that kind of thing.

Looking at

objdump -D arch/x86/kernel/x86_init.o

output, all the info is there in order to check whether a function ptr from
a .init section gets assigned to .data section structure.

Question is whether this is worth to put into objtool. From all the
objtool code I've seen flying by in recent years, we should pretty much
have everything needed so it should relatively easy to do.

But lemme add Josh and Peter...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2023-04-17  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-16 12:29 Borislav Petkov
2023-04-16 17:33 ` Linus Torvalds
2023-04-17  9:04   ` Borislav Petkov [this message]
2023-04-18  1:24     ` Josh Poimboeuf
2023-04-19 15:59       ` Borislav Petkov
2023-04-19 16:03         ` Juergen Gross
2023-04-19 16:44           ` Josh Poimboeuf
2023-04-16 17:43 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417090412.GAZD0LjH5ZIaGUdoHH@fat_crate.local \
    --to=bp@alien8.de \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®