From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF637C77B72 for ; Mon, 17 Apr 2023 11:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbjDQLmu (ORCPT ); Mon, 17 Apr 2023 07:42:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbjDQLmp (ORCPT ); Mon, 17 Apr 2023 07:42:45 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BAD8189 for ; Mon, 17 Apr 2023 04:41:50 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poNEh-0005FM-CY; Mon, 17 Apr 2023 13:41:31 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1poNEg-0006oc-7a; Mon, 17 Apr 2023 13:41:30 +0200 Date: Mon, 17 Apr 2023 13:41:30 +0200 From: Oleksij Rempel To: Vladimir Oltean Cc: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Woojung Huh , Arun Ramadoss , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next v1 2/2] net: dsa: microchip: Add partial ACL support for ksz9477 switches Message-ID: <20230417114130.GB11474@pengutronix.de> References: <20230411172456.3003003-1-o.rempel@pengutronix.de> <20230411172456.3003003-3-o.rempel@pengutronix.de> <20230413042936.GA12562@pengutronix.de> <20230416165904.2y7zwgyxwltjzj7m@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230416165904.2y7zwgyxwltjzj7m@skbuf> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 16, 2023 at 07:59:04PM +0300, Vladimir Oltean wrote: > On Thu, Apr 13, 2023 at 06:29:36AM +0200, Oleksij Rempel wrote: > > According to KSZ9477S 5.2.8.2 Port Priority Control Register > > "To achieve the desired functionality, do not set more than one bit at a > > time in this register. > > ... > > Bit 6 - OR’ed Priority > > ... > > Bit 2 - 802.1p Priority Classification > > Bit 1 - Diffserv Priority Classification > > Bit 0 - ACL Priority Classification > > " > > @Arun what will happen if multiple engines are used for packet > > prioritization? For example ACL || Diffserv || 802.1p... ? > > If I see it correctly, it is possible but not recommended. Should I > > prevent usage of multiple prio sources? > > You could try and find out which one takes priority... we support VLAN > PCP and DSCP prioritization through the dcbnl application priority table. According to my tests, ACL has higher priority compared to 802.1p module. dcbnl is a new word for me, will need to understand if first :) What is the best example to use it with DSCP? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |