From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26A4C77B76 for ; Mon, 17 Apr 2023 18:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjDQSO2 (ORCPT ); Mon, 17 Apr 2023 14:14:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjDQSOV (ORCPT ); Mon, 17 Apr 2023 14:14:21 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35907E48 for ; Mon, 17 Apr 2023 11:14:19 -0700 (PDT) Received: from zn.tnic (p5de8e687.dip0.t-ipconnect.de [93.232.230.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BB7381EC01A9; Mon, 17 Apr 2023 20:14:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1681755257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=3oAv63+EkEw6amRGtsM+gqDlCgqDrwGGKhHm2BH3LAo=; b=OsEf+rGAxvIeDCS1wiApbOSCjll5kBRnIuU5S8qFDf2zrPHelPQs/P0C/eo/BWSr4w8zvG XkJ48f7aCkLdDqNZ09uvGRGfvoOBrjLVCC4U4kYxfUPGQtlSKfTerC8HIcT5cDXA56C5Mz axgM+UoHVp5fBjLZi3AXWGQqEbIUOgM= Date: Mon, 17 Apr 2023 20:14:17 +0200 From: Borislav Petkov To: Willy Tarreau Cc: Jingbo Xu , tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, "linux-kernel@vger.kernel.org" Subject: Re: [BUG REPORT] arch/x86/include/asm/uaccess_64.h:119: Error: junk at end of line Message-ID: <20230417181417.GHZD2MeRSuMWUPEU3V@fat_crate.local> References: <20230314102316.GAZBBLFHKqQr9RSeM+@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 16, 2023 at 10:36:36AM +0200, Willy Tarreau wrote: > ... > So it just means that the support for the "U" suffix on numbers was > added in binutils 2.27 and the "L" suffix on numbers was added somewhere > between 2.27 and 2.29. Thanks for that - I'd like to document this once I've hashed out with the toolchain person the proper binutils versions which got this support. But that'll come later. > And given that there's a single occurrence of all this in the whole tree, > that's why I'm proposing to just get back to the good old (1 << 0) instead > of BIT(0). Yeah, we have those UC() macro things but they don't work in inline asm in C code. So yeah, pls do the thing you're suggesting. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette