From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ADD7C77B76 for ; Tue, 18 Apr 2023 03:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbjDRDSr (ORCPT ); Mon, 17 Apr 2023 23:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbjDRDSf (ORCPT ); Mon, 17 Apr 2023 23:18:35 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5D1E19A7; Mon, 17 Apr 2023 20:18:34 -0700 (PDT) Received: from kwepemi500013.china.huawei.com (unknown [7.221.188.120]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Q0pyG74F3zKsPW; Tue, 18 Apr 2023 11:17:42 +0800 (CST) Received: from M910t (10.110.54.157) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 11:18:31 +0800 Date: Tue, 18 Apr 2023 11:18:16 +0800 From: Changbin Du To: Changbin Du CC: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , , , Hui Wang Subject: Re: [PATCH v5 0/2] perf script: Have consistent output for symbol address Message-ID: <20230418031816.cm7yzbnvfonwdoub@M910t> References: <20230418031519.1261310-1-changbin.du@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230418031519.1261310-1-changbin.du@huawei.com> X-Originating-IP: [10.110.54.157] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500013.china.huawei.com (7.221.188.120) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org oops, I missed one patch. please ignore this. On Tue, Apr 18, 2023 at 11:15:17AM +0800, Changbin Du wrote: > The goal of this change is to achieve consistent output for symbol address. > Before this, the raw ip is printed for non-callchain and dso offset for > callchain. Mostly what we expect is the raw ip. > > This patch does two changes: > - Always print raw ip for resolved symbols. > - Add a new 'dsoff' field if we really need the dso offset, and the > offset is appended to dso name. > > v5: > o add helper map__fprintf_dsoname_dsoff() to eliminate repeated dso printing code. (Adrian) > o do not print offset for kernel dso (a.k.a [kernel.kallsyms]) > v4: > o also print 'dsoff' for brstack,brstacksym,brstackoff,etc. > v3: > o 'dsoff' implys 'dso' field. (Namhyung) > v2: > o split into two patches. (Adrian) > o do not print offset for unresolved symbols. (Adrian) > > Changbin Du (2): > perf: add helper map__fprintf_dsoname_dsoff > perf: script: add new output field 'dsoff' to print dso offset > > tools/perf/Documentation/perf-script.txt | 2 +- > tools/perf/builtin-script.c | 60 ++++++++++-------------- > tools/perf/util/evsel_fprintf.c | 16 +++---- > tools/perf/util/evsel_fprintf.h | 1 + > tools/perf/util/map.c | 13 +++++ > tools/perf/util/map.h | 1 + > 6 files changed, 46 insertions(+), 47 deletions(-) > > -- > 2.25.1 > -- Cheers, Changbin Du