From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E339CC6FD18 for ; Tue, 18 Apr 2023 20:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232548AbjDRUle (ORCPT ); Tue, 18 Apr 2023 16:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbjDRUlM (ORCPT ); Tue, 18 Apr 2023 16:41:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1698E9EFB for ; Tue, 18 Apr 2023 13:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681850426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q8kM5inZb2d3T//h4ttitFDvzuKHsR8ItNBjFDFDoTM=; b=RXP+aKQxyt+biO5yRDNKVIKL1NzvSTTCpeskGHV9DMxFMoiKGv0LZQSNXk5vlwyRTSKi81 nbL9ta1ouCx1WeywdHmrtPqJWmc+2/xwimDyFclUQ6sea0uCHb4/HpjIRCzUu/iyC0HQ4i /ZQQj7hd7CGKJ8mQCYZn/AH3zVKcKfg= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-nMG-zSpqP6GPnGrN_b39ZQ-1; Tue, 18 Apr 2023 16:40:24 -0400 X-MC-Unique: nMG-zSpqP6GPnGrN_b39ZQ-1 Received: by mail-il1-f200.google.com with SMTP id e9e14a558f8ab-32abae1ff3aso46082335ab.2 for ; Tue, 18 Apr 2023 13:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681850423; x=1684442423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q8kM5inZb2d3T//h4ttitFDvzuKHsR8ItNBjFDFDoTM=; b=fntP0JY3wMM3ZtHMtu+IkKgsFKyzYaPYQMhsrCgrvOJRcudBz2LEuo6R2e2cbZDnyL Mw6oPCEkn/4kR4GzOwvLPAfBqIXu3EmjvDjCwBXWQUFT0urIVGJpNIxkajE9P3E5C1IC GegM3QrNIzpdQR3uU8RunH0WdJx07+4YMrVI1KvzRQpJR/9COgRseUF8Md1Tr9zZSvI/ dVTdTtPO0+JXwhH7WML4eBbNXsl3EeYlRQ8z51lobJQKPSyxKlieVPMWDlXkNNkU/IGu Vbi8JMQu/NdPuui3l2+/SDEW0bKj3B3k33FJC1rcAkgyREHJ3Ep2J4HrpIRp0R9Ba4Id wACw== X-Gm-Message-State: AAQBX9f/4CmexchhPRwHZfWhhKHTX8OI0Ffcu3iwofnn7Di7OW7pZdYb /fhGjI8I8UE+L+r9izbFbh/WafGLNFHtT/cR6rjk0bIlXpWjBOO3Q3iafSBkgyVh6tY0n5vw020 oQmmIRmmrm8HcQLrFdUD1MCpF X-Received: by 2002:a92:c807:0:b0:329:4a17:4b17 with SMTP id v7-20020a92c807000000b003294a174b17mr1505934iln.21.1681850423738; Tue, 18 Apr 2023 13:40:23 -0700 (PDT) X-Google-Smtp-Source: AKy350YGtmkRKYs7vTtZBkNI5VoCiemSeU6gyMTNqv6GA2PgWmO5GhcU0tMeWb/4Z/6I5YajetDqQg== X-Received: by 2002:a92:c807:0:b0:329:4a17:4b17 with SMTP id v7-20020a92c807000000b003294a174b17mr1505926iln.21.1681850423487; Tue, 18 Apr 2023 13:40:23 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id a9-20020a056e020e0900b00328ab01a23fsm4063807ilk.14.2023.04.18.13.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 13:40:22 -0700 (PDT) Date: Tue, 18 Apr 2023 14:40:20 -0600 From: Alex Williamson To: "Gupta, Nipun" Cc: Jason Gunthorpe , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "masahiroy@kernel.org" , "nathan@kernel.org" , "ndesaulniers@google.com" , "nicolas@fjasle.eu" , "git (AMD-Xilinx)" , "Anand, Harpreet" , "Jansen Van Vuuren, Pieter" , "Agarwal, Nikhil" , "Simek, Michal" Subject: Re: [PATCH v4] vfio/cdx: add support for CDX bus Message-ID: <20230418144020.6b8368db.alex.williamson@redhat.com> In-Reply-To: References: <20230418113655.25207-1-nipun.gupta@amd.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Apr 2023 12:50:13 +0000 "Gupta, Nipun" wrote: > > -----Original Message----- > > From: Jason Gunthorpe > > Sent: Tuesday, April 18, 2023 5:40 PM > > To: Gupta, Nipun > > Cc: alex.williamson@redhat.com; linux-kernel@vger.kernel.org; > > kvm@vger.kernel.org; masahiroy@kernel.org; nathan@kernel.org; > > ndesaulniers@google.com; nicolas@fjasle.eu; git (AMD-Xilinx) ; > > Anand, Harpreet ; Jansen Van Vuuren, Pieter > > ; Agarwal, Nikhil > > ; Simek, Michal > > Subject: Re: [PATCH v4] vfio/cdx: add support for CDX bus > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > On Tue, Apr 18, 2023 at 05:06:55PM +0530, Nipun Gupta wrote: > > > > > diff --git a/drivers/vfio/Kconfig b/drivers/vfio/Kconfig > > > index 89e06c981e43..aba36f5be4ec 100644 > > > --- a/drivers/vfio/Kconfig > > > +++ b/drivers/vfio/Kconfig > > > @@ -57,6 +57,7 @@ source "drivers/vfio/pci/Kconfig" > > > source "drivers/vfio/platform/Kconfig" > > > source "drivers/vfio/mdev/Kconfig" > > > source "drivers/vfio/fsl-mc/Kconfig" > > > +source "drivers/vfio/cdx/Kconfig" > > > > keep sorted > > Since it is not sorted as of now, should a separate patch to be created for > sorting, before adding vfio-cdx? These are essentially in chronological order rather than alphabetical, so I don't really understand this request from Jason. Perhaps if it was already alphabetical the request would be justified, but I don't see any obligation here. > > > endif > > > > > > source "virt/lib/Kconfig" > > > diff --git a/drivers/vfio/Makefile b/drivers/vfio/Makefile > > > index 70e7dcb302ef..1a27b2516612 100644 > > > --- a/drivers/vfio/Makefile > > > +++ b/drivers/vfio/Makefile > > > @@ -14,3 +14,4 @@ obj-$(CONFIG_VFIO_PCI) += pci/ > > > obj-$(CONFIG_VFIO_PLATFORM) += platform/ > > > obj-$(CONFIG_VFIO_MDEV) += mdev/ > > > obj-$(CONFIG_VFIO_FSL_MC) += fsl-mc/ > > > +obj-$(CONFIG_VFIO_CDX) += cdx/ > > > > keep sorted > > Is there Linux guideline here on how objects and folders in Makefile are sorted, > as there are mix and match of files and folders in "drivers/vfio/Makefile". > I could not find any reference for sorting in other Makefiles as well. Same here, and I also don't know of a best practices reference that suggests an alphabetical ordering policy. > > > diff --git a/drivers/vfio/cdx/Makefile b/drivers/vfio/cdx/Makefile > > > new file mode 100644 > > > index 000000000000..82e4ef412c0f > > > --- /dev/null > > > +++ b/drivers/vfio/cdx/Makefile > > > @@ -0,0 +1,8 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +# > > > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc. > > > +# > > > + > > > +obj-$(CONFIG_VFIO_CDX) += vfio-cdx.o > > > + > > > +vfio-cdx-objs := vfio_cdx.o > > > > Linus has asked about "suttering" filenames before, suggest to call > > this > > > > "vfio/cdx/main.c" > > Okay, I do not any strong affiliation towards the name. > Alex, your thoughts on this please? I think Jason means "stuttering" file paths, or essentially self redundancy, ex. vfio/cdx/vfio_cdx.c. Yes, Linus has scolded us for vfio/pci/vfio_pci_* naming in the past, so in the spirit of not being further scolded I'd agree with the suggestion here. Thanks, Alex