From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH 1/4] ASoC: cs35l56: Update comment on masking of EINT20 interrupts
Date: Tue, 18 Apr 2023 15:43:06 +0100 [thread overview]
Message-ID: <20230418144309.1100721-2-rf@opensource.cirrus.com> (raw)
In-Reply-To: <20230418144309.1100721-1-rf@opensource.cirrus.com>
EINT20 contains wake-source interrupts and also interface-blocked
interrupts, which all default to unmasked after reset or wake.
The comment in cs35l56_init() only mentioned the wake interrupts.
Update the comment so it's clear that it's intentional to also
mask the *_BLOCKED interrupts.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/soc/codecs/cs35l56.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
index 0f4a94b02ef8..1b80cae5026e 100644
--- a/sound/soc/codecs/cs35l56.c
+++ b/sound/soc/codecs/cs35l56.c
@@ -1537,7 +1537,7 @@ int cs35l56_init(struct cs35l56_private *cs35l56)
cs35l56_patch(cs35l56->dev, cs35l56->regmap, cs35l56->rev);
- /* Wake source interrupts default to unmasked, so mask them */
+ /* Wake source and *_BLOCKED interrupts default to unmasked, so mask them */
regmap_write(cs35l56->regmap, CS35L56_IRQ1_MASK_20, 0xffffffff);
regmap_update_bits(cs35l56->regmap, CS35L56_IRQ1_MASK_1,
CS35L56_AMP_SHORT_ERR_EINT1_MASK,
--
2.30.2
next prev parent reply other threads:[~2023-04-18 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 14:43 [PATCH 0/4] ASoC: cs35l56: Updates for B0 silicon Richard Fitzgerald
2023-04-18 14:43 ` Richard Fitzgerald [this message]
2023-04-18 14:43 ` [PATCH 2/4] ASoC: cs35l56: Remove SDW1 TX5 and TX6 Richard Fitzgerald
2023-04-18 14:43 ` [PATCH 3/4] ASoC: cs35l56: Remove SDW2RX1 mixer source Richard Fitzgerald
2023-04-18 14:43 ` [PATCH 4/4] ASoC: cs35l56: Rename mixer source defines for SoundWire DP1 Richard Fitzgerald
2023-04-18 18:09 ` [PATCH 0/4] ASoC: cs35l56: Updates for B0 silicon Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418144309.1100721-2-rf@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®