From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B50C77B75 for ; Tue, 18 Apr 2023 18:39:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231566AbjDRSjD (ORCPT ); Tue, 18 Apr 2023 14:39:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbjDRSjA (ORCPT ); Tue, 18 Apr 2023 14:39:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 139428A78; Tue, 18 Apr 2023 11:38:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A207A6157C; Tue, 18 Apr 2023 18:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC3B5C433D2; Tue, 18 Apr 2023 18:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681843138; bh=yWZFzaHwyCv590iWQSNnSJIy2iMn1qsrmtyHHPDyNjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tTBz5/THNY2r5Qonb0/k6KdIPTIHWgikjyDPzf+X1CICN1lxEdutltpVPJoGX9pjy WqKOZpVRZY0q6nJQ3RYe7e/TfBBeAwCx/KAxR0U91xrWyi7lP9XovtLU+NONZAKO+d ScD0DiySwUAOGwN6xys/QurCg2R7yD0S+jMz7uXB3EzHsC+hWIXrQxXXdwrh9KYZsb hv8zIC7HPIQDTGQheaOg08pro71okyo8+t5cQAkm9ZZACzIDAombvSEk5qM+pAgezg Eub6hOrIbap1qAU3ilp1OiP7eZP79jSejWKR3iEkc0RiULl6Fq6pjpvJX0heVd5dnB +1GaFzUgj0nIQ== Date: Tue, 18 Apr 2023 11:38:56 -0700 From: Nathan Chancellor To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Nicolas Schier Subject: Re: [PATCH] kbuild: rpm-pkg: remove kernel-drm PROVIDES Message-ID: <20230418183856.GA2635379@dev-arch.thelio-3990X> References: <20230417143535.250565-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230417143535.250565-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 11:35:35PM +0900, Masahiro Yamada wrote: > This code was added more than 20 years ago. [1] > > I checked the kernel spec files in Fedora and OpenSUSE, but did not > see 'kernel-drm'. I do not know if there exists a distro that uses it > in RPM dependency. > > Remove this, and let's see if somebody complains about it. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=6d956df7d6b716b28c910c4f5b360c4d44d96c4d > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > scripts/package/mkspec | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > index fc8ad3fbc0a9..8049f0e2c110 100755 > --- a/scripts/package/mkspec > +++ b/scripts/package/mkspec > @@ -28,11 +28,6 @@ else > M=DEL > fi > > -if grep -q CONFIG_DRM=y include/config/auto.conf; then > - PROVIDES=kernel-drm > -fi > - > -PROVIDES="$PROVIDES kernel-$KERNELRELEASE" > __KERNELRELEASE=$(echo $KERNELRELEASE | sed -e "s/-/_/g") > EXCLUDES="$RCS_TAR_IGNORE --exclude=*vmlinux* --exclude=*.mod \ > --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation \ > @@ -55,7 +50,7 @@ sed -e '/^DEL/d' -e 's/^\t*//' < $S Source0: linux.tar.gz > $S Source1: config > $S Source2: diff.patch > - Provides: $PROVIDES > + Provides: kernel-$KERNELRELEASE > $S BuildRequires: bc binutils bison dwarves > $S BuildRequires: (elfutils-libelf-devel or libelf-devel) flex > $S BuildRequires: gcc make openssl openssl-devel perl python3 rsync > -- > 2.37.2 >