From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E962C77B73 for ; Wed, 19 Apr 2023 06:15:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbjDSGPj (ORCPT ); Wed, 19 Apr 2023 02:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbjDSGPd (ORCPT ); Wed, 19 Apr 2023 02:15:33 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D721996; Tue, 18 Apr 2023 23:15:30 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD1FC12F; Wed, 19 Apr 2023 08:15:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681884922; bh=rkUOMWQkU584u4Ts3QSMexZDobe08ycYK92hPZWwusc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=akrbepo9QwNMMW1Aba5GtEsYHKwgwhM2FVI4ESLzXhXlkN5m8E8uY6s/KrDh1Y5yp VlzHKEqzVEzYTIBC8LKnRe4ChQ6UbNGIGJfVDzUS2kp+PhdMkLuE96fubp6Xg7l3IM Z6q2r5Af1W6CPOw1HeKIk5PQ0aHci+Wn3fxHYY/c= Date: Wed, 19 Apr 2023 09:15:40 +0300 From: Laurent Pinchart To: Jack Zhu Cc: Mauro Carvalho Chehab , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , Robert Foss , Todor Tomov , Philipp Zabel , Ezequiel Garcia , Hans Verkuil , Eugen Hristev , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, changhuang.liang@starfivetech.com Subject: Re: [PATCH v4 6/8] media: dt-bindings: Add bindings for JH7110 Camera Subsystem Message-ID: <20230419061540.GB11679@pendragon.ideasonboard.com> References: <20230413035541.62129-1-jack.zhu@starfivetech.com> <20230413035541.62129-7-jack.zhu@starfivetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230413035541.62129-7-jack.zhu@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jack, Thank you for the patch. On Thu, Apr 13, 2023 at 11:55:39AM +0800, Jack Zhu wrote: > Add the bindings documentation for Starfive JH7110 Camera Subsystem > which is used for handing image sensor data. > > Signed-off-by: Jack Zhu > --- > .../bindings/media/starfive,jh7110-camss.yaml | 164 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 171 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > > diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > new file mode 100644 > index 000000000000..4cd144f1b845 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > @@ -0,0 +1,164 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive SoC CAMSS ISP > + > +maintainers: > + - Jack Zhu > + - Changhuang Liang > + > +description: > + The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It > + consists of a VIN controller (Video In Controller, a top-level control until) > + and an ISP. > + > +properties: > + compatible: > + const: starfive,jh7110-camss > + > + reg: > + maxItems: 2 > + > + reg-names: > + items: > + - const: syscon > + - const: isp > + > + clocks: > + maxItems: 7 > + > + clock-names: > + items: > + - const: apb_func > + - const: wrapper_clk_c > + - const: dvp_inv > + - const: axiwr > + - const: mipi_rx0_pxl > + - const: ispcore_2x > + - const: isp_axi > + > + resets: > + maxItems: 6 > + > + reset-names: > + items: > + - const: wrapper_p > + - const: wrapper_c > + - const: axird > + - const: axiwr > + - const: isp_top_n > + - const: isp_top_axi > + > + power-domains: > + items: > + - description: JH7110 ISP Power Domain Switch Controller. > + > + interrupts: > + maxItems: 4 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Input port for receiving DVP data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-width: > + const: 8 > + > + data-shift: > + const: 2 As far as I can tell, those two properties are not handled by the driver. I assume this is because the driver doesn't support the DVP input yet. That's fine, but it makes it a bit hard to review the device tree. Could you provide some information about the DVP hardware interface ? Does it support both BT.656 and sync signals, or just sync signals ? Are the polarities of the clock and h/v sync controllable ? Is the parallel input bus 8-bit wide or are other options supported ? And finally, what are you modelling with data-shift: 2 ? > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Input port for receiving CSI data. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - resets > + - reset-names > + - power-domains > + - interrupts > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + isp@19840000 { > + compatible = "starfive,jh7110-camss"; > + reg = <0x19840000 0x10000>, > + <0x19870000 0x30000>; > + reg-names = "syscon", "isp"; > + clocks = <&ispcrg 0>, > + <&ispcrg 13>, > + <&ispcrg 2>, > + <&ispcrg 12>, > + <&ispcrg 1>, > + <&syscrg 51>, > + <&syscrg 52>; > + clock-names = "apb_func", > + "wrapper_clk_c", > + "dvp_inv", > + "axiwr", > + "mipi_rx0_pxl", > + "ispcore_2x", > + "isp_axi"; > + resets = <&ispcrg 0>, > + <&ispcrg 1>, > + <&ispcrg 10>, > + <&ispcrg 11>, > + <&syscrg 41>, > + <&syscrg 42>; > + reset-names = "wrapper_p", > + "wrapper_c", > + "axird", > + "axiwr", > + "isp_top_n", > + "isp_top_axi"; > + power-domains = <&pwrc 5>; > + interrupts = <92>, <87>, <88>, <90>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + vin_from_sc2235: endpoint { > + remote-endpoint = <&sc2235_to_vin>; > + bus-width = <8>; > + data-shift = <2>; > + hsync-active = <1>; > + vsync-active = <0>; > + pclk-sample = <1>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + vin_from_csi2rx: endpoint { > + remote-endpoint = <&csi2rx_to_vin>; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index bbb8b5c0187b..b8c76b0d7eb3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19909,6 +19909,13 @@ M: Ion Badulescu > S: Odd Fixes > F: drivers/net/ethernet/adaptec/starfire* > > +STARFIVE CAMERA SUBSYSTEM DRIVER > +M: Jack Zhu > +M: Changhuang Liang > +L: linux-media@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml > + > STARFIVE DEVICETREES > M: Emil Renner Berthing > S: Maintained -- Regards, Laurent Pinchart