mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: xieyongji@bytedance.com, jasowang@redhat.com, mst@redhat.com,
	david.marchand@redhat.com
Cc: linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [RFC 1/2] vduse: validate block features only with block devices
Date: Wed, 19 Apr 2023 15:43:28 +0200	[thread overview]
Message-ID: <20230419134329.346825-2-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20230419134329.346825-1-maxime.coquelin@redhat.com>

This patch is preliminary work to enable network device
type support to VDUSE.

As VIRTIO_BLK_F_CONFIG_WCE shares the same value as
VIRTIO_NET_F_HOST_TSO4, we need to restrict its check
to Virtio-blk device type.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/vdpa/vdpa_user/vduse_dev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 0c3b48616a9f..6fa598a03d8e 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -1416,13 +1416,14 @@ static bool device_is_allowed(u32 device_id)
 	return false;
 }
 
-static bool features_is_valid(u64 features)
+static bool features_is_valid(struct vduse_dev_config *config)
 {
-	if (!(features & (1ULL << VIRTIO_F_ACCESS_PLATFORM)))
+	if (!(config->features & (1ULL << VIRTIO_F_ACCESS_PLATFORM)))
 		return false;
 
 	/* Now we only support read-only configuration space */
-	if (features & (1ULL << VIRTIO_BLK_F_CONFIG_WCE))
+	if ((config->device_id == VIRTIO_ID_BLOCK) &&
+			(config->features & (1ULL << VIRTIO_BLK_F_CONFIG_WCE)))
 		return false;
 
 	return true;
@@ -1446,7 +1447,7 @@ static bool vduse_validate_config(struct vduse_dev_config *config)
 	if (!device_is_allowed(config->device_id))
 		return false;
 
-	if (!features_is_valid(config->features))
+	if (!features_is_valid(config))
 		return false;
 
 	return true;
-- 
2.39.2


  reply	other threads:[~2023-04-19 13:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 13:43 [RFC 0/2] vduse: add support for networking devices Maxime Coquelin
2023-04-19 13:43 ` Maxime Coquelin [this message]
2023-04-20  4:06   ` [RFC 1/2] vduse: validate block features only with block devices Jason Wang
2023-04-20 10:22     ` Maxime Coquelin
2023-04-19 13:43 ` [RFC 2/2] vduse: enable Virtio-net device type Maxime Coquelin
2023-04-20  4:34 ` [RFC 0/2] vduse: add support for networking devices Jason Wang
2023-04-20 14:16   ` Maxime Coquelin
2023-04-21  5:51     ` Jason Wang
2023-04-21 14:28       ` Maxime Coquelin
2023-04-23  6:30         ` Jason Wang
2023-04-23  8:22           ` Yongji Xie
2023-04-24  3:42             ` Jason Wang
2023-04-20 18:39   ` Peter Xu
2023-04-21  7:08     ` Jason Wang
2023-04-20  8:13 ` Yongji Xie
2023-04-20 14:23   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230419134329.346825-2-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®