From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2B2C77B7E for ; Thu, 20 Apr 2023 10:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231921AbjDTKe0 (ORCPT ); Thu, 20 Apr 2023 06:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234837AbjDTKeA (ORCPT ); Thu, 20 Apr 2023 06:34:00 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E5A33A8E; Thu, 20 Apr 2023 03:31:33 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AA6295AA; Thu, 20 Apr 2023 12:31:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681986684; bh=tjVakFAz0Ke+8se6BRvkXETbHQDz2JkaQ00st7I+unQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=goLCMkQRNxIRsJSzE8F1qhc5PVyKdH41mFbJtQWehPpdzrr+sXBA5BkTOPBwK0rYh RV8YdxJCymGObZGIJ1ie/+kWmhfqd+EoO4gqW0oUndlztjZ6tl46qyqsFxMLktBIG6 eL77XBJbsQZKS7klEuM1uoChG0QM1lKZnNO7rG8M= Date: Thu, 20 Apr 2023 13:31:43 +0300 From: Laurent Pinchart To: Dmitry Perchanov Cc: linux-media@vger.kernel.org, mchehab@kernel.org, linux-kernel@vger.kernel.org, evgeni.raikhel@intel.com, demisrael@gmail.com, sakari.ailus@iki.fi Subject: Re: [PATCH v3] media: uvcvideo: Enable Intel RealSense metadata for devices. Message-ID: <20230420103143.GB11005@pendragon.ideasonboard.com> References: <5587a4f1a0a7f3e2bd0ce886bb4ee3bcbf8f522a.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5587a4f1a0a7f3e2bd0ce886bb4ee3bcbf8f522a.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Thank you for the patch. On Thu, Apr 20, 2023 at 12:06:55PM +0300, Dmitry Perchanov wrote: > Intel RealSense UVC Depth cameras produce metadata in a > vendor-specific format that is already supported by the uvcvideo driver. > Enable handling of this metadata for 7 additional RealSense devices. > > Co-developed-by: Yu MENG > Co-developed-by: Evgeni Raikhel > Signed-off-by: Dmitry Perchanov Reviewed-by: Laurent Pinchart I will wait for the answer to Sakari's question before merging this though. > --- > drivers/media/usb/uvc/uvc_driver.c | 63 ++++++++++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 7aefa76a42b3..f69573e2de96 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -3014,6 +3014,33 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, > + /* Intel D410/ASR depth camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0ad2, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D415/ASRC depth camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0ad3, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D430/AWG depth camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0ad4, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > /* Intel RealSense D4M */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > | USB_DEVICE_ID_MATCH_INT_INFO, > @@ -3023,6 +3050,42 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = 0, > .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D435/AWGC depth camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0b07, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D435i depth camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0b3a, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D405 Depth Camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0b5b, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > + /* Intel D455 Depth Camera */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x8086, > + .idProduct = 0x0b5c, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = 0, > + .driver_info = UVC_INFO_META(V4L2_META_FMT_D4XX) }, > /* Generic USB Video Class */ > { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_UNDEFINED) }, > { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_15) }, -- Regards, Laurent Pinchart