From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47C1C77B73 for ; Thu, 20 Apr 2023 13:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230483AbjDTNAh (ORCPT ); Thu, 20 Apr 2023 09:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbjDTNAd (ORCPT ); Thu, 20 Apr 2023 09:00:33 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6345FFB; Thu, 20 Apr 2023 06:00:30 -0700 (PDT) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 1FE2E3F182; Thu, 20 Apr 2023 13:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1681995628; bh=gVcupUjqxy/2MFJa9BjLN3mhC36GLHdtoZUwAf/ZhO8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KBT8UofdrHu5ROxkheXj+W2JRg5H/a/0UtSI4W/I74Cv0fm7kYf9pCYkKeLfqSqsE wNd+F31u1D6qVML+XmUEtLWTD/QGTkZCH2+ESH57wfzYx3IXFKpxGMozrHJJV3dKEj +Uwsvj3GD4tYWGDcms2lpv8mG2lb2EypZHHGy2ep1/z9yVqkhxKvsrhjIojE/6CyOE fnJmu953hXb0XxqwH6+SJLO2QCsDV5trGjwdbGBSFH0FlbL3MpWLqbr2mQZXPxeE44 mTwD5aczOULvDmLDb611aclY5G1KuEwgjrMqdBiJQpRMkrO+tp2vyvYtx9XMIrXbvq hb0HHPyvbUO3w== From: Kai-Heng Feng To: bhelgaas@google.com Cc: mika.westerberg@linux.intel.com, koba.ko@canonical.com, sathyanarayanan.kuppuswamy@linux.intel.com, Kai-Heng Feng , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] PCI: Keep AER status in pci_restore_state() Date: Thu, 20 Apr 2023 20:59:37 +0800 Message-Id: <20230420125941.333675-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When AER is using the same IRQ as PME, AER interrupt is treated as a wakeup event and it can disrupt system suspend process. If that happens, the system will report it's woken up by PME IRQ without indicating any AER error since AER status is cleared on resume. So keep the AER status so users can know the system is woken up by AER instead of PME. Reviewed-by: Mika Westerberg Signed-off-by: Kai-Heng Feng --- v3: - No change. v2: - New patch. drivers/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7a67611dc5f4..71aead00fc20 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1778,7 +1778,6 @@ void pci_restore_state(struct pci_dev *dev) pci_restore_dpc_state(dev); pci_restore_ptm_state(dev); - pci_aer_clear_status(dev); pci_restore_aer_state(dev); pci_restore_config_space(dev); -- 2.34.1