From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2F3C7618E for ; Fri, 21 Apr 2023 17:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233492AbjDURtR (ORCPT ); Fri, 21 Apr 2023 13:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233508AbjDURsz (ORCPT ); Fri, 21 Apr 2023 13:48:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2C6A526A for ; Fri, 21 Apr 2023 10:48:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B40F629FA for ; Fri, 21 Apr 2023 17:48:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CA67C4339B; Fri, 21 Apr 2023 17:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682099319; bh=Ii+umwiPLgHoqPjWpVsscc+8uzYEd6xFhrolQQm/Ak8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WXAcwdQ02eP9WM94jFJIStkVwvRoVn12l3/Io2y38uhwsw+tNWbH4bNgCYFKEh25l qZ8FWbQt7DAwviohxha0vPtzUfrl7RIfUJ/LqBIMwEvZW8WwMiLPAGCLAPo6P8beN5 +wR15BdwtJtgCaO7tp9lGGeA1O3OWGcKRPRSDmHERG+H5otPnykPSYxqXGiSlJv++g 5+DHYuK3epfiIGN3eWjSBfKLzPz/L4aTy6CeIOZmV+fvGPibtvyBYPTnpacP9ODO5P eDrTjm9oxC1q3+7td1u/XZimFrB0cJs+hbzzhRHWOyygItlvwxnvzyQMQL0ibIxqza /4yfpIY/6Vqow== Date: Fri, 21 Apr 2023 18:48:34 +0100 From: Conor Dooley To: Evan Green Cc: Palmer Dabbelt , Albert Ou , Andrew Jones , Conor Dooley , Guo Ren , Heiko Stuebner , Jisheng Zhang , Palmer Dabbelt , Paul Walmsley , Philipp Tomsich , Samuel Holland , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] RISC-V: hwprobe: Remove __init on probe_vendor_features() Message-ID: <20230421-humpback-thesis-052993278582@spud> References: <20230420194934.1871356-1-evan@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aRxAucu+VMU5sivz" Content-Disposition: inline In-Reply-To: <20230420194934.1871356-1-evan@rivosinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --aRxAucu+VMU5sivz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yo Evan, On Thu, Apr 20, 2023 at 12:49:34PM -0700, Evan Green wrote: > probe_vendor_features() is now called from smp_callin(), which is not > __init code and runs during cpu hotplug events. Remove the > __init_or_module decoration from it and the functions it calls to avoid > walking into outer space. >=20 > Fixes: 62a31d6e38bd ("RISC-V: hwprobe: Support probing of misaligned acce= ss performance") > BTW, in the future, no empty line between trailers. > Signed-off-by: Evan Green Otherwise, Reviewed-by: Conor Dooley Thanks, Conor. --aRxAucu+VMU5sivz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZELMcgAKCRB4tDGHoIJi 0r4oAP9MpkA95QmPfsVGArIe3XYGzsfJ9qessAghtLLA7WxNPQEA7mgwhKGzi3dJ ox2EWtciEAdDRS5RDGNln4ou3RSMWwo= =JmiQ -----END PGP SIGNATURE----- --aRxAucu+VMU5sivz--