From: Al Viro <viro@zeniv.linux.org.uk>
To: Kirtikumar Anandrao Ramchandani <kirtiar15502@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
"cc: Greg KH" <gregkh@linuxfoundation.org>,
security@kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: Patch for a overwriting/corruption of the file system
Date: Fri, 21 Apr 2023 04:00:17 +0100 [thread overview]
Message-ID: <20230421030017.GA3390869@ZenIV> (raw)
In-Reply-To: <CADZg-m1uBXit9gX0bcZQ3vWvg34J_sLX-df32x+JX=bjtJeg0w@mail.gmail.com>
On Wed, Mar 15, 2023 at 02:33:48PM +0530, Kirtikumar Anandrao Ramchandani wrote:
> While I am going through the code at the moment, I think there is one more
> issue. It probably can't just compare "old_dir" and "new_dir", since those
> are just pointers to structs. So, both addresses can be completely
> different, and still represent the same folder, yes?
No, they can not. We should never have different in-core instances of
struct inode representing the same on-disk object - otherwise all locking
goes to hell, for example.
next prev parent reply other threads:[~2023-04-21 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADZg-m0Z+dOGfG=ddJxqPvgFwG0+OLAyP157SNzj6R6J2p7L-g@mail.gmail.com>
2023-03-13 10:16 ` Greg KH
[not found] ` <CADZg-m04XELrO-v-uYZ4PyYHXVPX35dgWbCHBpZvwepS4XV9Ew@mail.gmail.com>
[not found] ` <CADZg-m2k_L8-byX0WKYw5Cj1JPPhxk3HCBexpqPtZvcLRNY8Ug@mail.gmail.com>
2023-03-13 10:32 ` Greg KH
2023-03-14 9:55 ` Christian Brauner
2023-03-14 16:57 ` Al Viro
2023-03-14 17:13 ` Christian Brauner
[not found] ` <CADZg-m3w_xJ3cQS=+-yb7iS5PJg8kGHntMb7poP6tOsOXvnDeQ@mail.gmail.com>
[not found] ` <CADZg-m1uBXit9gX0bcZQ3vWvg34J_sLX-df32x+JX=bjtJeg0w@mail.gmail.com>
2023-04-21 3:00 ` Al Viro [this message]
2023-04-21 3:05 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421030017.GA3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirtiar15502@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=security@kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®