From: kernel test robot <lkp@intel.com>
To: Chris Down <chris@chrisdown.name>, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Petr Mladek <pmladek@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
kernel-team@fb.com
Subject: Re: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
Date: Fri, 21 Apr 2023 05:54:29 +0800 [thread overview]
Message-ID: <202304210550.jdh8v273-lkp@intel.com> (raw)
In-Reply-To: <43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris@chrisdown.name>
Hi Chris,
kernel test robot noticed the following build errors:
[auto build test ERROR on cb0856346a60fe3eb837ba5e73588a41f81ac05f]
url: https://github.com/intel-lab-lkp/linux/commits/Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
base: cb0856346a60fe3eb837ba5e73588a41f81ac05f
patch link: https://lore.kernel.org/r/43d7f8d6e4b45a1a76fceef2d117bbc3954bc0bf.1681994221.git.chris%40chrisdown.name
patch subject: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console
config: arc-randconfig-r043-20230416 (https://download.01.org/0day-ci/archive/20230421/202304210550.jdh8v273-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/db9fb81bc5f175ef48cb317c24da85d0f6d4391d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chris-Down/printk-Do-not-delay-messages-which-aren-t-solicited-by-any-console/20230420-204202
git checkout db9fb81bc5f175ef48cb317c24da85d0f6d4391d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs// kernel/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304210550.jdh8v273-lkp@intel.com/
All errors (new ones prefixed by >>):
kernel/printk/printk.c: In function 'boot_delay_msec':
>> kernel/printk/printk.c:1297:64: error: expected ')' before 'return'
1297 | if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
| ~ ^
| )
1298 | return;
| ~~~~~~
>> kernel/printk/printk.c:1315:1: error: expected expression before '}' token
1315 | }
| ^
kernel/printk/printk.c:1295:23: warning: unused variable 'timeout' [-Wunused-variable]
1295 | unsigned long timeout;
| ^~~~~~~
kernel/printk/printk.c:1294:28: warning: unused variable 'k' [-Wunused-variable]
1294 | unsigned long long k;
| ^
vim +1297 kernel/printk/printk.c
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1291
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1292 static void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1293 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1294 unsigned long long k;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1295 unsigned long timeout;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1296
ff48cd26fc4889 kernel/printk/printk.c Thomas Gleixner 2017-05-16 @1297 if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1298 return;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1299
3a3b6ed2235f2f kernel/printk.c Dave Young 2009-09-22 1300 k = (unsigned long long)loops_per_msec * boot_delay;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1301
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1302 timeout = jiffies + msecs_to_jiffies(boot_delay);
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1303 while (k) {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1304 k--;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1305 cpu_relax();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1306 /*
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1307 * use (volatile) jiffies to prevent
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1308 * compiler reduction; loop termination via jiffies
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1309 * is secondary and may or may not happen.
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1310 */
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1311 if (time_after(jiffies, timeout))
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1312 break;
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1313 touch_nmi_watchdog();
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1314 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 @1315 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1316 #else
db9fb81bc5f175 kernel/printk/printk.c Chris Down 2023-04-20 1317 static inline void boot_delay_msec(void)
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1318 {
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1319 }
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1320 #endif
bfe8df3d314bdd kernel/printk.c Randy Dunlap 2007-10-16 1321
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-04-20 21:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:39 [PATCH v4 0/2] printk: console: Per-console loglevels Chris Down
2023-04-20 12:39 ` [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console Chris Down
2023-04-20 13:27 ` John Ogness
2023-04-20 13:47 ` Chris Down
2023-04-20 21:54 ` kernel test robot [this message]
2023-04-21 0:18 ` kernel test robot
2023-04-21 8:59 ` kernel test robot
2023-04-20 12:39 ` [PATCH v4 2/2] printk: console: Support console-specific loglevels Chris Down
2023-04-25 14:57 ` Petr Mladek
2023-04-27 13:53 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304210550.jdh8v273-lkp@intel.com \
--to=lkp@intel.com \
--cc=chris@chrisdown.name \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®