mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Yang <yang.yang29@zte.com.cn>
To: vbabka@suse.cz, akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, iamjoonsoo.kim@lge.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	rppt@kernel.org, yang.yang29@zte.com.cn
Subject: Re: [PATCH linux-next v2] mm: workingset: update description of the source file
Date: Fri, 21 Apr 2023 19:31:30 +0800	[thread overview]
Message-ID: <20230421113130.240586-1-yang.yang29@zte.com.cn> (raw)
In-Reply-To: <0ddb50f0-2e2d-e750-3867-3842a3ea12cc@suse.cz>

> I'm late but FWIW, not supper happy that while the updated calculations are
> now accurate wrt the actual code, the explanation (which was written at the
> time of page cache-only workinset) was more easier to follow in the simpler
> form. Now it's still mostly talking about page cache and explaining the
>balance between its active and inactive list only, and then suddenly the
> anon lists appear out of nowhere in the final equations.

Thanks for your reviewing! I should update the whole parts. Sorry for
hadn't do it better, please drop the patch, I will try to submit patchv3
to fix this.

> In other words, I think it would have been better to leave that explanation
> as it was, and then add a new part describing the extension to anon pages.

I read the description of the source file again carefully, and think that
there is no need to creat a new part, if we explain at the begining that
the word 'pages' include page cache and anonymous page, and do some minor 
adjustments. For example:
Per node, two kinds of clock lists are maintained for pages..

  reply	other threads:[~2023-04-21 11:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  8:34 yang.yang29
2023-04-21  9:59 ` Vlastimil Babka
2023-04-21 11:31   ` Yang Yang [this message]
2023-04-24 14:21     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421113130.240586-1-yang.yang29@zte.com.cn \
    --to=yang.yang29@zte.com.cn \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®