From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6AECC7618E for ; Fri, 21 Apr 2023 12:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231576AbjDUMy7 (ORCPT ); Fri, 21 Apr 2023 08:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjDUMy5 (ORCPT ); Fri, 21 Apr 2023 08:54:57 -0400 Received: from outbound-smtp15.blacknight.com (outbound-smtp15.blacknight.com [46.22.139.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8794D1B1 for ; Fri, 21 Apr 2023 05:54:56 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp15.blacknight.com (Postfix) with ESMTPS id 26F031C3F46 for ; Fri, 21 Apr 2023 13:54:55 +0100 (IST) Received: (qmail 6123 invoked from network); 21 Apr 2023 12:54:55 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 12:54:54 -0000 Date: Fri, 21 Apr 2023 13:54:53 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 06/26] mm: page_alloc: consolidate free page accounting Message-ID: <20230421125453.np6b5hirktkj6ji5@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-7-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 03:12:53PM -0400, Johannes Weiner wrote: > Free page accounting currently happens a bit too high up the call > stack, where it has to deal with guard pages, compaction capturing, > block stealing and even page isolation. This is subtle and fragile, > and makes it difficult to hack on the code. > > Push the accounting down to where pages enter and leave the physical > freelists, where all these higher-level exceptions are of no concern. > > Signed-off-by: Johannes Weiner I didn't look too closely at this one as I'm scanning through to see how the overall series works and this is mostly a mechanical patch. However, it definitely breaks build > @@ -843,7 +843,7 @@ static int __init debug_guardpage_minorder_setup(char *buf) > early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup); > > static inline bool set_page_guard(struct zone *zone, struct page *page, > - unsigned int order, int migratetype) > + unsigned int order > { > if (!debug_guardpage_enabled()) > return false; Here -- Mel Gorman SUSE Labs