From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605B1C77B71 for ; Fri, 21 Apr 2023 14:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232699AbjDUOdr (ORCPT ); Fri, 21 Apr 2023 10:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232690AbjDUOdm (ORCPT ); Fri, 21 Apr 2023 10:33:42 -0400 Received: from outbound-smtp51.blacknight.com (outbound-smtp51.blacknight.com [46.22.136.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA5110DD for ; Fri, 21 Apr 2023 07:33:01 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp51.blacknight.com (Postfix) with ESMTPS id 3835CFACF2 for ; Fri, 21 Apr 2023 15:33:00 +0100 (IST) Received: (qmail 23535 invoked from network); 21 Apr 2023 14:32:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 14:32:59 -0000 Date: Fri, 21 Apr 2023 15:32:58 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 13/26] mm: compaction: remove compaction result helpers Message-ID: <20230421143258.c24oytksvehbqs5w@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-14-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-14-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 03:13:00PM -0400, Johannes Weiner wrote: > I found myself repeatedly looking up the implementation of these > helpers while working on the code, which suggests they are not a > helpful abstraction. Inline them. > > Signed-off-by: Johannes Weiner Not massively convinced one way or the other. Still, probably deserves to join the end of the preparation patch before MIGRATE_FREE is introduced in the interest in spltting the series into digestable pieces. -- Mel Gorman SUSE Labs