From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15746C77B71 for ; Fri, 21 Apr 2023 14:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232983AbjDUOyD (ORCPT ); Fri, 21 Apr 2023 10:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbjDUOx6 (ORCPT ); Fri, 21 Apr 2023 10:53:58 -0400 Received: from outbound-smtp29.blacknight.com (outbound-smtp29.blacknight.com [81.17.249.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0EC4AF20 for ; Fri, 21 Apr 2023 07:53:57 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp29.blacknight.com (Postfix) with ESMTPS id 33029BED8C for ; Fri, 21 Apr 2023 15:39:31 +0100 (IST) Received: (qmail 27573 invoked from network); 21 Apr 2023 14:39:31 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 14:39:31 -0000 Date: Fri, 21 Apr 2023 15:39:29 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 15/26] mm: compaction: simplify free block check in suitable_migration_target() Message-ID: <20230421143929.riofzlnmn2dgqfc7@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-16-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-16-hannes@cmpxchg.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023 at 03:13:02PM -0400, Johannes Weiner wrote: > Free page blocks are now marked MIGRATE_FREE. Consult that directly. > > Signed-off-by: Johannes Weiner Justification for patch depends on whether MIGRATE_FREE is itself necessaary. Even then, it's a micro-optimisation but maybe it matters more later. -- Mel Gorman SUSE Labs