From: Adam Ford <aford173@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: m.szyprowski@samsung.com, aford@beaconembedded.com,
dario.binacchi@amarulasolutions.com, l.stach@pengutronix.de,
Adam Ford <aford173@gmail.com>, Inki Dae <inki.dae@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Marek Vasut <marex@denx.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH V2 3/6] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically
Date: Sun, 23 Apr 2023 07:12:29 -0500 [thread overview]
Message-ID: <20230423121232.1345909-4-aford173@gmail.com> (raw)
In-Reply-To: <20230423121232.1345909-1-aford173@gmail.com>
Make the pll-clock-frequency optional. If it's present, use it
to maintain backwards compatibility with existing hardware. If it
is absent, read clock rate of "sclk_mipi" to determine the rate.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
drivers/gpu/drm/bridge/samsung-dsim.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index adb9c13c5f7f..5b6e7825b92f 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1726,12 +1726,20 @@ static int samsung_dsim_parse_dt(struct samsung_dsim *dsi)
{
struct device *dev = dsi->dev;
struct device_node *node = dev->of_node;
+ struct clk *pll_clk;
int ret;
ret = samsung_dsim_of_read_u32(node, "samsung,pll-clock-frequency",
&dsi->pll_clk_rate);
- if (ret < 0)
- return ret;
+
+ /* If it doesn't exist, read it from the clock instead of failing */
+ if (ret < 0) {
+ pll_clk = devm_clk_get(dev, "sclk_mipi");
+ if (!IS_ERR(pll_clk))
+ dsi->pll_clk_rate = clk_get_rate(pll_clk);
+ else
+ return PTR_ERR(pll_clk);
+ }
ret = samsung_dsim_of_read_u32(node, "samsung,burst-clock-frequency",
&dsi->burst_clk_rate);
--
2.39.2
next prev parent reply other threads:[~2023-04-23 12:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 12:12 [PATCH V2 0/6] drm: bridge: samsung-dsim: Support variable clocking Adam Ford
2023-04-23 12:12 ` [PATCH V2 1/6] drm: bridge: samsung-dsim: fix blanking packet size calculation Adam Ford
2023-04-24 9:03 ` Jagan Teki
2023-04-24 9:47 ` Adam Ford
2023-05-03 16:35 ` Jagan Teki
2023-05-04 7:14 ` Lucas Stach
2023-04-23 12:12 ` [PATCH V2 2/6] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp] Adam Ford
2023-04-24 6:53 ` Lucas Stach
2023-04-23 12:12 ` Adam Ford [this message]
2023-04-23 12:12 ` [PATCH V2 4/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing Adam Ford
2023-04-24 6:12 ` Chen-Yu Tsai
2023-04-24 9:31 ` Adam Ford
2023-04-24 9:44 ` Chen-Yu Tsai
2023-04-24 9:47 ` Marek Szyprowski
2023-04-24 9:50 ` Adam Ford
2023-04-24 12:48 ` Adam Ford
2023-04-23 12:12 ` [PATCH V2 5/6] drm: bridge: samsung-dsim: Support non-burst mode Adam Ford
2023-04-24 8:25 ` Marek Szyprowski
2023-04-24 10:00 ` Adam Ford
2023-04-28 12:31 ` Marek Szyprowski
2023-04-28 13:35 ` Adam Ford
2023-04-28 14:04 ` Marek Szyprowski
2023-04-28 14:09 ` Adam Ford
2023-04-23 12:12 ` [PATCH V2 6/6] drm: bridge: samsung-dsim: Let blanking calcuation work in " Adam Ford
2023-04-24 7:20 ` [PATCH V2 0/6] drm: bridge: samsung-dsim: Support variable clocking Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230423121232.1345909-4-aford173@gmail.com \
--to=aford173@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford@beaconembedded.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®