mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "D. Starke" <daniel.starke@siemens.com>
To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com>
Subject: [PATCH v3 3/8] tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config
Date: Mon, 24 Apr 2023 09:52:46 +0200	[thread overview]
Message-ID: <20230424075251.5216-3-daniel.starke@siemens.com> (raw)
In-Reply-To: <20230424075251.5216-1-daniel.starke@siemens.com>

From: Daniel Starke <daniel.starke@siemens.com>

The variable 'ret' is not used before assignment from gsm_activate_mux().
Still it gets initialized to zero at declaration.

Fix this as remarked in the link below by moving the declaration to the
first assignment.

Link: https://lore.kernel.org/all/b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org/

Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
---
 drivers/tty/n_gsm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

v2 -> v3:
No changes.

Link: https://lore.kernel.org/all/20230420085017.7314-4-daniel.starke@siemens.com/

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 00f692e2e810..9a2cf3e14678 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -3277,7 +3277,6 @@ static void gsm_copy_config_values(struct gsm_mux *gsm,
 
 static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
 {
-	int ret = 0;
 	int need_close = 0;
 	int need_restart = 0;
 
@@ -3356,7 +3355,7 @@ static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
 	 * and removing from the mux array
 	 */
 	if (gsm->dead) {
-		ret = gsm_activate_mux(gsm);
+		int ret = gsm_activate_mux(gsm);
 		if (ret)
 			return ret;
 		if (gsm->initiator)
-- 
2.34.1


  parent reply	other threads:[~2023-04-24  7:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  7:52 [PATCH v3 1/8] tty: n_gsm: add restart parameter to DLC specific ioctl config D. Starke
2023-04-24  7:52 ` [PATCH v3 2/8] tty: n_gsm: add missing description to gsm_config D. Starke
2023-04-24  7:52 ` D. Starke [this message]
2023-04-24  7:52 ` [PATCH v3 4/8] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-04-24  7:52 ` [PATCH v3 5/8] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-04-24  7:52 ` [PATCH v3 6/8] tty: n_gsm: increase gsm_mux unsupported counted where appropriate D. Starke
2023-04-24  7:52 ` [PATCH v3 7/8] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-04-24  7:52 ` [PATCH v3 8/8] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke
2023-04-24 10:54 ` [PATCH v3 1/8] tty: n_gsm: add restart parameter to DLC specific ioctl config Greg KH
2023-04-24 11:03   ` Starke, Daniel
2023-04-24 12:54     ` Greg KH
2023-04-24 13:20       ` Ilpo Järvinen
2023-04-24 16:41         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424075251.5216-3-daniel.starke@siemens.com \
    --to=daniel.starke@siemens.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®