From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DB5C77B71 for ; Tue, 25 Apr 2023 11:24:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233795AbjDYLYK (ORCPT ); Tue, 25 Apr 2023 07:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233451AbjDYLYH (ORCPT ); Tue, 25 Apr 2023 07:24:07 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B7F29D for ; Tue, 25 Apr 2023 04:24:06 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 161EF4B3; Tue, 25 Apr 2023 04:24:50 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 59D923F5A1; Tue, 25 Apr 2023 04:24:04 -0700 (PDT) Date: Tue, 25 Apr 2023 12:24:01 +0100 From: Sudeep Holla To: "lihuisong (C)" Cc: Krzysztof Kozlowski , andersson@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, shawnguo@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, soc@kernel.org, wanghuiqiang@huawei.com, tanxiaofei@huawei.com, Sudeep Holla , liuyonglong@huawei.com, huangdaode@huawei.com Subject: Re: [PATCH] soc: hisilicon: Support HCCS driver on Kunpeng SoC Message-ID: <20230425112401.d4oggwwrzdgnnss7@bogus> References: <20230424073020.4039-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2023 at 11:16:32AM +0800, lihuisong (C) wrote: > Hi Krzysztof, > Thanks for your review. My reply is as follows. > > 在 2023/4/24 16:42, Krzysztof Kozlowski 写道: [...] > > Maybe leave a comment that all these are ACPI-only and are not allowed > > in DT usage. Without bindings we are not going to review them. OTOH, I > > think we don't have a process for such cases in general. > Thanks for your suggestion. will add it. Please look at my response and continue the discussion as why _CRS can't be used[1] before you add any DT bindings. I would prefer to avoid any DSD style properties especially if it is used only in ACPI. -- Regards, Sudeep [1] https://lore.kernel.org/all/20230425103040.znv66k364ant6klq@bogus/