From: Tomas Mudrunka <tomas.mudrunka@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Tomas Mudrunka <tomas.mudrunka@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix freeze in lm8333 i2c keyboard driver
Date: Tue, 25 Apr 2023 15:00:53 +0200 [thread overview]
Message-ID: <20230425130054.591007-1-tomas.mudrunka@gmail.com> (raw)
LM8333 uses gpio interrupt line which is active-low.
When interrupt is set to FALLING edge and button is pressed
before driver loads, driver will miss the edge and never respond.
To fix this we handle ONESHOT LOW interrupt rather than edge.
Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
---
drivers/input/keyboard/lm8333.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 7457c3220..c5770ebb2 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -179,7 +179,7 @@ static int lm8333_probe(struct i2c_client *client)
}
err = request_threaded_irq(client->irq, NULL, lm8333_irq_thread,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"lm8333", lm8333);
if (err)
goto free_mem;
--
2.40.0
next reply other threads:[~2023-04-25 13:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 13:00 Tomas Mudrunka [this message]
2023-04-25 15:39 ` Jeff LaBundy
2023-04-25 16:49 ` [PATCH v2] " Tomas Mudrunka
2023-04-27 0:41 ` Jeff LaBundy
2023-04-27 8:13 ` Tomáš Mudruňka
2023-04-27 18:47 ` Jeff LaBundy
2023-04-28 10:09 ` [PATCH v3] " Tomas Mudrunka
2023-04-28 10:20 ` [PATCH v4] " Tomas Mudrunka
2023-05-03 3:02 ` Jeff LaBundy
2023-05-03 8:54 ` Tomáš Mudruňka
2023-05-03 15:32 ` [PATCH v5] " Tomas Mudrunka
2023-05-04 1:44 ` Jeff LaBundy
2023-05-11 23:44 ` Dmitry Torokhov
2023-05-12 16:54 ` Jeff LaBundy
2023-05-12 16:55 ` Tomáš Mudruňka
2023-05-12 17:28 ` Jeff LaBundy
2023-11-14 12:30 ` [PATCH v6] " Tomas Mudrunka
2023-12-14 2:24 ` Jeff LaBundy
2023-12-15 15:56 ` [PATCH v7] " Tomas Mudrunka
2025-02-19 14:51 ` Tomas Mudrunka
2023-04-26 23:16 ` [PATCH] " Dmitry Torokhov
2023-04-27 0:27 ` Jeff LaBundy
2023-04-27 8:19 ` Tomáš Mudruňka
2023-04-27 18:54 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425130054.591007-1-tomas.mudrunka@gmail.com \
--to=tomas.mudrunka@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®