mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	maple-tree@lists.infradead.org,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range()
Date: Tue, 25 Apr 2023 10:09:54 -0400	[thread overview]
Message-ID: <20230425140955.3834476-34-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20230425140955.3834476-1-Liam.Howlett@oracle.com>

Add the testing for the new functions to iterate per range.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 lib/test_maple_tree.c | 148 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 148 insertions(+)

diff --git a/lib/test_maple_tree.c b/lib/test_maple_tree.c
index 7b2d19ad5934d..adbf59542951b 100644
--- a/lib/test_maple_tree.c
+++ b/lib/test_maple_tree.c
@@ -3356,6 +3356,150 @@ static noinline void __init check_state_handling(struct maple_tree *mt)
 	mas_unlock(&mas);
 }
 
+static noinline void __init check_slot_iterators(struct maple_tree *mt)
+{
+	MA_STATE(mas, mt, 0, 0);
+	unsigned long i, index = 40;
+	unsigned char offset = 0;
+	void *test;
+
+	mt_set_non_kernel(99999);
+
+	mas_lock(&mas);
+	for (i = 0; i <= index; i++) {
+		unsigned long end = 5;
+		if (i > 20 && i < 35)
+			end = 9;
+		mas_set_range(&mas, i*10, i*10 + end);
+		mas_store_gfp(&mas, xa_mk_value(i), GFP_KERNEL);
+	}
+
+	i = 21;
+	mas_set(&mas, i*10);
+	MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != NULL);
+	MAS_BUG_ON(&mas, mas.index != 206);
+	MAS_BUG_ON(&mas, mas.last != 209);
+
+	i--;
+	MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.index != 200);
+	MAS_BUG_ON(&mas, mas.last != 205);
+
+	i = 25;
+	mas_set(&mas, i*10);
+	MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.offset != 0);
+
+	/* Previous range is in another node */
+	i--;
+	MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.index != 240);
+	MAS_BUG_ON(&mas, mas.last != 249);
+
+	/* Shift back with mas_next */
+	i++;
+	MAS_BUG_ON(&mas, mas_next_range(&mas, ULONG_MAX) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.index != 250);
+	MAS_BUG_ON(&mas, mas.last != 259);
+
+	i = 33;
+	mas_set(&mas, i*10);
+	MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.index != 330);
+	MAS_BUG_ON(&mas, mas.last != 339);
+
+	/* Next range is in another node */
+	i++;
+	MAS_BUG_ON(&mas, mas_next_range(&mas, ULONG_MAX) != xa_mk_value(i));
+	MAS_BUG_ON(&mas, mas.offset != 0);
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+
+	/* Next out of range */
+	i++;
+	MAS_BUG_ON(&mas, mas_next_range(&mas, i*10 - 1) != NULL);
+	/* maple state does not move */
+	MAS_BUG_ON(&mas, mas.offset != 0);
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+
+	/* Prev out of range */
+	i--;
+	MAS_BUG_ON(&mas, mas_prev_range(&mas, i*10 + 1) != NULL);
+	/* maple state does not move */
+	MAS_BUG_ON(&mas, mas.offset != 0);
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+
+	mas_set(&mas, 210);
+	for (i = 210; i<= 350; i += 10) {
+		void *entry = mas_find_range(&mas, ULONG_MAX);
+
+		MAS_BUG_ON(&mas, entry != xa_mk_value(i/10));
+	}
+
+	mas_set(&mas, 0);
+	mas_contiguous(&mas, test, ULONG_MAX) {
+		MAS_BUG_ON(&mas, test != xa_mk_value(0));
+		MAS_BUG_ON(&mas, mas.index != 0);
+		MAS_BUG_ON(&mas, mas.last != 5);
+	}
+	MAS_BUG_ON(&mas, test != NULL);
+	MAS_BUG_ON(&mas, mas.index != 6);
+	MAS_BUG_ON(&mas, mas.last != 9);
+
+	mas_set(&mas, 6);
+	mas_contiguous(&mas, test, ULONG_MAX) {
+		MAS_BUG_ON(&mas, test != xa_mk_value(1));
+		MAS_BUG_ON(&mas, mas.index != 10);
+		MAS_BUG_ON(&mas, mas.last != 15);
+	}
+	MAS_BUG_ON(&mas, test != NULL);
+	MAS_BUG_ON(&mas, mas.index != 16);
+	MAS_BUG_ON(&mas, mas.last != 19);
+
+	i = 210;
+	mas_set(&mas, i);
+	mas_contiguous(&mas, test, 340) {
+		MAS_BUG_ON(&mas, test != xa_mk_value(i/10));
+		MAS_BUG_ON(&mas, mas.index != i);
+		MAS_BUG_ON(&mas, mas.last != i+9);
+		i+=10;
+		offset = mas.offset;
+	}
+	/* Hit the limit, iterator is at the limit. */
+	MAS_BUG_ON(&mas, offset != mas.offset);
+	MAS_BUG_ON(&mas, test != NULL);
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+	test = mas_find_range(&mas, ULONG_MAX);
+	MAS_BUG_ON(&mas, test != xa_mk_value(35));
+	MAS_BUG_ON(&mas, mas.index != 350);
+	MAS_BUG_ON(&mas, mas.last != 355);
+
+
+	test = mas_find_range_rev(&mas, 0);
+	MAS_BUG_ON(&mas, test != xa_mk_value(34));
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+	mas_set(&mas, 345);
+	test = mas_find_range_rev(&mas, 0);
+	MAS_BUG_ON(&mas, test != xa_mk_value(34));
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+
+	offset = mas.offset;
+	test = mas_find_range_rev(&mas, 340);
+	MAS_BUG_ON(&mas, offset != mas.offset);
+	MAS_BUG_ON(&mas, test != NULL);
+	MAS_BUG_ON(&mas, mas.index != 340);
+	MAS_BUG_ON(&mas, mas.last != 349);
+
+	mas_unlock(&mas);
+	mt_set_non_kernel(0);
+}
+
 static DEFINE_MTREE(tree);
 static int __init maple_tree_seed(void)
 {
@@ -3621,6 +3765,10 @@ static int __init maple_tree_seed(void)
 	check_state_handling(&tree);
 	mtree_destroy(&tree);
 
+	mt_init_flags(&tree, MT_FLAGS_ALLOC_RANGE);
+	check_slot_iterators(&tree);
+	mtree_destroy(&tree);
+
 #if defined(BENCH)
 skip:
 #endif
-- 
2.39.2


  parent reply	other threads:[~2023-04-25 16:30 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 14:09 [PATCH 00/34] Maple tree mas_{next,prev}_range() and cleanup Liam R. Howlett
2023-04-25 14:09 ` [PATCH 01/34] maple_tree: Fix static analyser cppcheck issue Liam R. Howlett
2023-04-26  4:06   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 02/34] maple_tree: Clean up mas_parent_enum() Liam R. Howlett
2023-04-25 16:13   ` Wei Yang
2023-04-26  4:14   ` Peng Zhang
2023-04-26 21:07     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 03/34] maple_tree: Avoid unnecessary ascending Liam R. Howlett
2023-04-26  5:27   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 04/34] maple_tree: Clean up mas_dfs_postorder() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 05/34] maple_tree: Add format option to mt_dump() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 06/34] maple_tree: Add debug BUG_ON and WARN_ON variants Liam R. Howlett
2023-04-25 14:09 ` [PATCH 07/34] maple_tree: Convert BUG_ON() to MT_BUG_ON() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 08/34] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 09/34] maple_tree: Convert debug code to use MT_WARN_ON() and MAS_WARN_ON() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 10/34] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent Liam R. Howlett
2023-04-28 10:08   ` Petr Tesařík
2023-05-03 19:31     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 11/34] maple_tree: Use MAS_BUG_ON() in mas_set_height() Liam R. Howlett
2023-04-28 10:10   ` Petr Tesařík
2023-05-03 19:33     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 12/34] maple_tree: Use MAS_BUG_ON() from mas_topiary_range() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 13/34] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 14/34] maple_tree: Use MAS_BUG_ON() prior to calling mas_meta_gap() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 15/34] maple_tree: Return error on mte_pivots() out of range Liam R. Howlett
2023-04-26  9:55   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 16/34] maple_tree: Make test code work without debug enabled Liam R. Howlett
2023-04-26  3:23   ` kernel test robot
2023-04-25 14:09 ` [PATCH 17/34] mm: Update validate_mm() to use vma iterator Liam R. Howlett
2023-04-25 14:09 ` [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON() Liam R. Howlett
2023-04-27  1:07   ` Sergey Senozhatsky
2023-04-27  1:17     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 19/34] maple_tree: Add __init and __exit to test module Liam R. Howlett
2023-04-25 14:09 ` [PATCH 20/34] maple_tree: Remove unnecessary check from mas_destroy() Liam R. Howlett
2023-04-26  9:59   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 21/34] maple_tree: mas_start() reset depth on dead node Liam R. Howlett
2023-04-28  2:45   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 22/34] mm/mmap: Change do_vmi_align_munmap() for maple tree iterator changes Liam R. Howlett
2023-04-25 14:09 ` [PATCH 23/34] maple_tree: Try harder to keep active node after mas_next() Liam R. Howlett
2023-05-04  2:44   ` kernel test robot
2023-04-25 14:09 ` [PATCH 24/34] maple_tree: Try harder to keep active node with mas_prev() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 25/34] maple_tree: Clear up index and last setting in single entry tree Liam R. Howlett
2023-04-27 11:19   ` Peng Zhang
2023-04-27 17:25     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 26/34] maple_tree: Update testing code for mas_{next,prev,walk} Liam R. Howlett
2023-05-04  3:33   ` Peng Zhang
2023-05-04 18:50     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface Liam R. Howlett
2023-04-26  1:21   ` kernel test robot
2023-04-26 13:16   ` kernel test robot
2023-04-28  6:48   ` Peng Zhang
2023-05-03 19:31     ` Liam R. Howlett
2023-04-28  8:39   ` kernel test robot
2023-04-25 14:09 ` [PATCH 28/34] maple_tree: Revise limit checks in mas_empty_area{_rev}() Liam R. Howlett
2023-04-28  7:06   ` Peng Zhang
2023-04-25 14:09 ` [PATCH 29/34] maple_tree: Introduce mas_prev_slot() interface Liam R. Howlett
2023-04-28  8:27   ` Peng Zhang
2023-05-03 19:29     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 30/34] maple_tree: Fix comments for mas_next_entry() and mas_prev_entry() Liam R. Howlett
2023-04-25 14:09 ` [PATCH 31/34] maple_tree: Add mas_next_range() and mas_find_range() interfaces Liam R. Howlett
2023-04-25 14:09 ` [PATCH 32/34] maple_tree: Add mas_prev_range() and mas_find_range_rev interface Liam R. Howlett
2023-04-25 14:09 ` Liam R. Howlett [this message]
2023-04-26  1:41   ` [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range() kernel test robot
2023-05-05 17:11     ` Liam R. Howlett
2023-04-25 14:09 ` [PATCH 34/34] mm: Add vma_iter_{next,prev}_range() to vma iterator Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425140955.3834476-34-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®