From: Yangtao Li <frank.li@vivo.com>
To: jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: no need test opt for f2fs_issue_flush
Date: Wed, 26 Apr 2023 00:58:57 +0800 [thread overview]
Message-ID: <20230425165857.29175-1-frank.li@vivo.com> (raw)
This information can now be obtained from the mount, and there isi
no need to print it out every time the trace event is triggered.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
fs/f2fs/segment.c | 3 +--
include/trace/events/f2fs.h | 13 +++----------
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 6db410f1bb8c..2683c4dd3bd5 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -519,8 +519,7 @@ static int __submit_flush_wait(struct f2fs_sb_info *sbi,
{
int ret = blkdev_issue_flush(bdev);
- trace_f2fs_issue_flush(bdev, test_opt(sbi, NOBARRIER),
- test_opt(sbi, FLUSH_MERGE), ret);
+ trace_f2fs_issue_flush(bdev, ret);
if (!ret)
f2fs_update_iostat(sbi, NULL, FS_FLUSH_IO, 0);
return ret;
diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 99cbc5949e3c..2a94c1d2e012 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -1535,29 +1535,22 @@ TRACE_EVENT(f2fs_issue_reset_zone,
TRACE_EVENT(f2fs_issue_flush,
- TP_PROTO(struct block_device *dev, unsigned int nobarrier,
- unsigned int flush_merge, int ret),
+ TP_PROTO(struct block_device *dev, int ret),
- TP_ARGS(dev, nobarrier, flush_merge, ret),
+ TP_ARGS(dev, ret),
TP_STRUCT__entry(
__field(dev_t, dev)
- __field(unsigned int, nobarrier)
- __field(unsigned int, flush_merge)
__field(int, ret)
),
TP_fast_assign(
__entry->dev = dev->bd_dev;
- __entry->nobarrier = nobarrier;
- __entry->flush_merge = flush_merge;
__entry->ret = ret;
),
- TP_printk("dev = (%d,%d), %s %s, ret = %d",
+ TP_printk("dev = (%d,%d), ret = %d",
show_dev(__entry->dev),
- __entry->nobarrier ? "skip (nobarrier)" : "issue",
- __entry->flush_merge ? " with flush_merge" : "",
__entry->ret)
);
--
2.39.0
next reply other threads:[~2023-04-25 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 16:58 Yangtao Li [this message]
2023-06-13 8:01 ` Yangtao Li
2023-06-19 5:20 ` Chao Yu
2023-06-20 6:21 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425165857.29175-1-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®