From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kilobyte@angband.pl
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mei: deduplicate X86 && PCI dependencies, make them apply to all subentries
Date: Tue, 25 Apr 2023 18:16:36 +0200 [thread overview]
Message-ID: <2023042519-spookily-vocalist-51d2@gregkh> (raw)
In-Reply-To: <20230425154314.21728-1-kilobyte@angband.pl>
On Tue, Apr 25, 2023 at 05:43:14PM +0200, kilobyte@angband.pl wrote:
> From: Adam Borowski <kilobyte@angband.pl>
>
> The Kconfig "depends on X86 && PCI" line was repeated for 4 out of 6 config
> symbols here -- which was both unnecessarily repetitive, and caused a
> dormant problem for the two remaining symbols lacking the dependency.
>
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
> v2: instead of adding new depends, wrap all of mei in "if..endif"
>
> drivers/misc/mei/Kconfig | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
> index d21486d69df2..f2ab2696fa78 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -1,8 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0
> # Copyright (c) 2003-2019, Intel Corporation. All rights reserved.
> +if X86 && PCI
Please no, that's not a normal Kconfig thing to do at all, sorry.
greg k-h
next prev parent reply other threads:[~2023-04-25 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 13:51 [PATCH] mei: make hdcp and pxp depend on X86 && PCI kilobyte
2023-04-25 4:39 ` Winkler, Tomas
2023-04-25 11:52 ` Adam Borowski
2023-04-25 13:40 ` Greg Kroah-Hartman
2023-04-25 15:27 ` Adam Borowski
2023-04-25 15:43 ` [PATCH v2] mei: deduplicate X86 && PCI dependencies, make them apply to all subentries kilobyte
2023-04-25 16:16 ` Greg Kroah-Hartman [this message]
2023-04-25 21:51 ` [PATCH] mei: make hdcp and pxp depend on X86 && PCI Arnd Bergmann
2023-04-26 18:11 ` Winkler, Tomas
2023-04-28 5:50 ` Arnd Bergmann
2023-04-30 6:38 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023042519-spookily-vocalist-51d2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®