From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C6FC77B73 for ; Wed, 26 Apr 2023 03:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239031AbjDZDXH (ORCPT ); Tue, 25 Apr 2023 23:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbjDZDXD (ORCPT ); Tue, 25 Apr 2023 23:23:03 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D310E5E for ; Tue, 25 Apr 2023 20:23:02 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id D0EE8E1CFB; Wed, 26 Apr 2023 11:23:00 +0800 (CST) From: Yang Yang To: mingo@redhat.com Cc: surenb@google.com, hannes@cmpxchg.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, yang.yang29@zte.com.cn, peterz@infradead.org Subject: Re: [PATCH linux-next] sched/psi: avoid unnecessary resetting min update period when destroy trigger Date: Wed, 26 Apr 2023 11:23:00 +0800 Message-Id: <20230426032300.14980-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >On Mon, Apr 17, 2023 at 1:12 AM wrote: >> >> From: Yang Yang >> >> Psi_group's poll_min_period is determined by the min window size of >> psi_trigger when creating new triggers. While destroying a psi_trigger, >> there is no need to reset poll_min_period if the destroying psi_trigger >> not had the min windows size, since in this condition poll_min_period >> will keep the same as before. > > Nice optimization. > >> Signed-off-by: Yang Yang > Acked-by: Suren Baghdasaryan Hi, would you please take a review? Thanks!