On Fri, Apr 28, 2023 at 10:16:01PM +0800, Yangyu Chen wrote: > From: Conor Dooley > > "Ease of parsing" may have been the initial argument for keeping this > string in lower-case, but parsers may have been written that expect > lower-case only. > For example, the one in released kernels currently does not behave > correctly for multi-letter extensions that begin with a capital letter. > Allowing upper-case here brings about no benefit but would break > compatibility between new devicetrees and older kernels. > > Drop the comment to avoid confusing people. > > Signed-off-by: Conor Dooley You missed an Acked-by from Rob here: https://lore.kernel.org/all/168261158214.3107331.4410018416833510357.robh@kernel.org/ Also, when you are submitting a patch authored by another person, you need to append your Signed-off-by to the patch ;) Cheers, Conor. > --- > Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml > index 001931d526ec..1ee97621d0c7 100644 > --- a/Documentation/devicetree/bindings/riscv/cpus.yaml > +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml > @@ -81,7 +81,7 @@ properties: > > While the isa strings in ISA specification are case > insensitive, letters in the riscv,isa string must be all > - lowercase to simplify parsing. > + lowercase. > $ref: "/schemas/types.yaml#/definitions/string" > pattern: ^rv(?:64|32)imaf?d?q?c?b?k?j?p?v?h?(?:[hsxz](?:[a-z])+)?(?:_[hsxz](?:[a-z])+)*$ > > -- > 2.40.0 >