From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918BDC7EE30 for ; Mon, 1 May 2023 03:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234193AbjEADVG (ORCPT ); Sun, 30 Apr 2023 23:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233158AbjEADRD (ORCPT ); Sun, 30 Apr 2023 23:17:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7CE01BFE; Sun, 30 Apr 2023 20:07:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EF9261735; Mon, 1 May 2023 03:06:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEEFC433EF; Mon, 1 May 2023 03:06:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682910417; bh=DcjXekO6d7vfiiA44MWWCEOPfLjA8/jcAX3MbvESGyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tv68HYR0WRx1mbAsgZfkQLVzPxNSn8bhz1+kDubU/fBLzSUsguecd+yUnAlIl0vXx wlFls98h7W4BDmrgbEZIz8SRHqT5UC38xtPZARXLx//hdyxm0iydmQrHy8kzJelnFn zhMFnX3eEQMwc3tSpig4St2z7xyPWDs0SCv0ZrehoCUHpDhPf5ukKusMTSFLoWih2h Ihx1Y+OlOuvyMEB3lhbHNdsZTEPwNhmcXI0ZCUsID+okhBN6pIkFbeWni9a0yjJQZK u5gSMvumF1NXQZmvKB9UJrk90Ror5XpBHyTOvjFzA/q2Rv72KC+GKNVTAexRucE/89 2PoLkRnc0TvyA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Armin Wolf , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 3/6] ACPI: EC: Fix oops when removing custom query handlers Date: Sun, 30 Apr 2023 23:06:49 -0400 Message-Id: <20230501030653.3255321-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230501030653.3255321-1-sashal@kernel.org> References: <20230501030653.3255321-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Armin Wolf [ Upstream commit e5b492c6bb900fcf9722e05f4a10924410e170c1 ] When removing custom query handlers, the handler might still be used inside the EC query workqueue, causing a kernel oops if the module holding the callback function was already unloaded. Fix this by flushing the EC query workqueue when removing custom query handlers. Tested on a Acer Travelmate 4002WLMi Signed-off-by: Armin Wolf Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/ec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index f8fc30be68711..1dedab328c464 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -1135,6 +1135,7 @@ static void acpi_ec_remove_query_handlers(struct acpi_ec *ec, void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit) { acpi_ec_remove_query_handlers(ec, false, query_bit); + flush_workqueue(ec_query_wq); } EXPORT_SYMBOL_GPL(acpi_ec_remove_query_handler); -- 2.39.2