From: Peter Zijlstra <peterz@infradead.org>
To: chris hyser <chris.hyser@oracle.com>
Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
vincent.guittot@linaro.org, Chen Yu <yu.c.chen@intel.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4] sched/numa: Fix divide by zero for sysctl_numa_balancing_scan_size.
Date: Mon, 1 May 2023 20:55:33 +0200 [thread overview]
Message-ID: <20230501185533.GD1597476@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3fdc9c92-4a4f-b716-c8bc-056111feb3e0@oracle.com>
On Mon, May 01, 2023 at 12:21:17PM -0400, chris hyser wrote:
> In terms of actually wanting to fix this, I'm a bit confused. It clearly was
> worth fixing the first time around (it has your sign-off), and the only
> thing that has changed is that that fix no longer works.
Well, the amount of effort to fix it has dramatically increased, 40+
extra lines vs 2 extra lines.
> > If we do find we want this (why?!) then should we not invest in a better
> > debugfs_create_u32_minmax() or something so that we don't get to add 40+
> > lines for everthing we want to add limits on?
>
> I will look at a way to greatly simplify the bounds checking here as you
> suggest.
Thanks, that might make it all a lot nicer indeed.
prev parent reply other threads:[~2023-05-01 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 15:26 chris hyser
2023-04-29 14:56 ` Peter Zijlstra
2023-05-01 16:21 ` chris hyser
2023-05-01 18:55 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501185533.GD1597476@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chris.hyser@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®